feat: add eagle3 spec decoding for minicpm#8842
Open
LDLINGLINGLING wants to merge 7 commits intosgl-project:mainfrom
Open
feat: add eagle3 spec decoding for minicpm#8842LDLINGLINGLING wants to merge 7 commits intosgl-project:mainfrom
LDLINGLINGLING wants to merge 7 commits intosgl-project:mainfrom
Conversation
Contributor
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
Collaborator
|
I have submitted it, but it hasn't been reviewed yet: #6899 |
6 tasks
mickqian
reviewed
Sep 8, 2025
Collaborator
mickqian
left a comment
There was a problem hiding this comment.
Please talk with @yhyang201 with his pr #6899
mickqian
approved these changes
Sep 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Added the Eagle3 speculative decoding feature to the MiniCPM model
Modifications
Added several functions to support Eagle3 in /model/MiniCPM.py, primarily to retrieve hidden layers from the target model.
Accuracy Test
Benchmark & Profiling
<!
-->
Checklist