[feat] Append full messages instead of role and content#5907
Closed
shuaills wants to merge 8 commits intosgl-project:mainfrom
Closed
[feat] Append full messages instead of role and content#5907shuaills wants to merge 8 commits intosgl-project:mainfrom
shuaills wants to merge 8 commits intosgl-project:mainfrom
Conversation
Co-authored-by: tuhahaha <tujianhong.tjh@alibaba-inc.com>
Collaborator
|
LGTM |
minleminzui
approved these changes
Apr 30, 2025
minleminzui
suggested changes
Apr 30, 2025
Collaborator
minleminzui
left a comment
There was a problem hiding this comment.
@shuaills please check the ci
Collaborator
|
It seems the CI is failing due to the change in |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The changes in the adapter are made to ensure that all fields from the original message (not just role and content) are preserved when constructing openai_compatible_messages.
This is important because:
Some downstream logic or templates may need access to extra fields like tool_calls, reasoning_content, etc.
Chat template should have control to those fields instead of removing them in SGLang side.
Modifications
Checklist