Skip to content

Followup to fix the arctic model#5768

Closed
vincentzed wants to merge 19 commits intosgl-project:mainfrom
vincentzed:zv/fix-arctic
Closed

Followup to fix the arctic model#5768
vincentzed wants to merge 19 commits intosgl-project:mainfrom
vincentzed:zv/fix-arctic

Conversation

@vincentzed
Copy link
Copy Markdown
Contributor

@vincentzed vincentzed commented Apr 27, 2025 •
edited
Loading

Motivation

Some import error, we didn't update the code, this is erroneous, corrected now.

Modifications

Update the imports in ArcticForCausalLM

Checklist

@vincentzed vincentzed force-pushed the zv/fix-arctic branch 6 times, most recently from c046201 to da76ce5 Compare April 30, 2025 03:20
@vincentzed
isort and reword the message
04d8337 
to pass the CI ? transient failure.
@vincentzed
Copy link
Copy Markdown
Contributor Author

vincentzed commented Apr 30, 2025

Hey @merrymercy if you could take a quick peek.

@vincentzed vincentzed marked this pull request as ready for review April 30, 2025 04:02
@vincentzed
Copy link
Copy Markdown
Contributor Author

vincentzed commented Apr 30, 2025

The failure, it's unrelated?

The message was: Cell execution timed out.
Here is a preview of the cell contents:
-------------------
['# Non-streaming mode test', 'response_non_stream = client.chat.completions.create(', '    model=model_name,', '    messages=messages,', '    temperature=0.1,']
...
['print(response_non_stream)', 'print_highlight("==== content ====")', 'print(response_non_stream.choices[0].message.content)', 'print_highlight("==== tool_calls ====")', 'print(response_non_stream.choices[0].message.tool_calls)']

@zhaochenyang20
Copy link
Copy Markdown
Collaborator

zhaochenyang20 commented Apr 30, 2025

sure. let me ask lianmin to reivew

@b8zhong
Copy link
Copy Markdown
Collaborator

b8zhong commented May 8, 2025

Hi @merrymercy , wondering if you have the bandwidth to re-review. Thanks 👍

@b8zhong b8zhong mentioned this pull request Jun 21, 2025
Closed
81 tasks
@vincentzed vincentzed closed this Aug 24, 2025
@vincentzed vincentzed deleted the zv/fix-arctic branch August 24, 2025 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@merrymercy merrymercy Awaiting requested review from merrymercy

@Ying1123 Ying1123 Awaiting requested review from Ying1123

@hnyls2002 hnyls2002 Awaiting requested review from hnyls2002

@zhyncs zhyncs Awaiting requested review from zhyncs

@ispobock ispobock Awaiting requested review from ispobock

@ByronHsu ByronHsu Awaiting requested review from ByronHsu

@zhaochenyang20 zhaochenyang20 Awaiting requested review from zhaochenyang20

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vincentzed @zhaochenyang20 @b8zhong