[Model] Add support for nvidia/Llama-3_3-Nemotron-Super-49B-v1#5073
Closed
kylehh wants to merge 15 commits intosgl-project:mainfrom
Closed
[Model] Add support for nvidia/Llama-3_3-Nemotron-Super-49B-v1#5073kylehh wants to merge 15 commits intosgl-project:mainfrom
kylehh wants to merge 15 commits intosgl-project:mainfrom
Conversation
5 tasks
merrymercy
requested changes
Apr 27, 2025
| def __call__(self, layer_id: int, prefix: str) -> torch.nn.Module: ... | ||
|
|
||
|
|
||
| class PPMissingLayer(torch.nn.Identity): |
Contributor
There was a problem hiding this comment.
Do not add these first. Can you drop all of them?
Contributor
Author
There was a problem hiding this comment.
Missinglayer class was migrated from vllm implementation, which was created by Nemotron team. Keep it for code consistent and future proof. Do these cause the failure of CI pipeline?
Collaborator
|
@kylehh please rebase. thanks. |
Contributor
|
Hello @merrymercy @zhyncs! |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Add support for nvidia/Llama-3_3-Nemotron-Super-49B-v1
Modifications
Migration nemotron_nas from vllm
Checklist