[Fix] Fix raw_bs bug when using flashinfer mla and eagle#4557
Merged
zhyncs merged 1 commit intosgl-project:mainfrom Mar 19, 2025
Merged
[Fix] Fix raw_bs bug when using flashinfer mla and eagle#4557zhyncs merged 1 commit intosgl-project:mainfrom
zhyncs merged 1 commit intosgl-project:mainfrom
Conversation
5 tasks
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Fix the bug mentioned in #4536: when
bs != raw_bswhen eagle replays cuda graph,seq_len_cpuneeded by flashinfer mla needs to be handled.Modifications
Fix bug
Accuracy
Launch
GSM8K
MMLU
Benchmark
Benchmark results of this PR on 8*H200. Throughput (tokens/sec) is used as the metric. Benchmark results before this PR can be found in #4218 for reference. Launching command is the same as in accuracy tests.
Input-4000-Output-200
Input-128-Output-128
One Prompt
Acc Length = 3.03
Throughput = 74.70 tokens/s
Checklist