Skip to content

refactor: rewrite bench-mmmu-sglang#4458

Merged
zhyncs merged 1 commit intosgl-project:mainfrom
mickqian:mmmu
Mar 18, 2025
Merged

refactor: rewrite bench-mmmu-sglang#4458
zhyncs merged 1 commit intosgl-project:mainfrom
mickqian:mmmu

Conversation

@mickqian
Copy link
Copy Markdown
Collaborator

@mickqian mickqian commented Mar 15, 2025

Motivation

  1. Replace prev impl with a server-request style.

Backend-Frontend does not work in this scenario, since image data is not supported in SglImage

  1. use image file as image input across hf and sglang to improve consistency

Modifications

Checklist

@zhaochenyang20
Copy link
Copy Markdown
Collaborator

@simveit could you please take a look?

Comment thread benchmark/mmmu/bench_sglang.py Outdated
Comment thread benchmark/mmmu/bench_sglang.py Outdated
Comment thread benchmark/mmmu/bench_sglang.py Outdated
@simveit
Copy link
Copy Markdown
Contributor

simveit commented Mar 17, 2025

apart from the minor issues i commented on it looks good to me @zhaochenyang20 @mickqian

@mickqian mickqian force-pushed the mmmu branch 2 times, most recently from c8c0b51 to b90812e Compare March 17, 2025 09:03
@mickqian
Copy link
Copy Markdown
Collaborator Author

@zhaochenyang20 @simveit all resolved. thanks

@simveit simveit mentioned this pull request Mar 17, 2025
6 tasks
@ravi03071991
Copy link
Copy Markdown
Collaborator

ravi03071991 commented Mar 17, 2025

@mickqian small typo in README.md.

It should be - python -m sglang.launch_server --model-path Qwen/Qwen2-VL-7B-Instruct --port 30000

Replace prev impl with a server-request style.

Backend-Frontend does not work in this scenario, since image data is not supported in SglImage
@zhyncs zhyncs merged commit 98be3bd into sgl-project:main Mar 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants