[ROCm] Enable silu_and_mul, gelu_and_mul, gelu_tanh_and_mul in amd platform#4150
Closed
yiakwy-xpu-ml-framework-team wants to merge 5 commits intosgl-project:mainfrom
Closed
Conversation
d526a98 to
a5f032c
Compare
18 tasks
Contributor
|
Could you rebase and move them under https://github.com/sgl-project/sglang/tree/main/sgl-kernel/csrc/elementwise? |
Contributor
Author
@merrymercy thank you . WIP. |
6 tasks
Contributor
Author
|
@merrymercy move to #4432 cc @BBuf |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Decouple vllm dependencies and enable activation in amd platform. See issue#2965
This is followed up PR#3702. Prefer to merge PR#3702 first.
Modifications
Correctness
Checklist