[Bug Fix] Add partial rotary factor support for Phi-4 and upgrade to transformers v4.50.0#3984
Merged
zhyncs merged 54 commits intosgl-project:mainfrom Mar 22, 2025
Merged
Conversation
Collaborator
Author
|
@zhaochenyang20 ready to be reviewed. Some inconsistencies in the CI with accuracy but should be good |
Collaborator
|
@adarshxs thanks. yi and me can help to rerun the CI. @yizhang2077 could you help to review this? |
Collaborator
Author
|
@zhaochenyang20 @yizhang2077 any update on this? |
yizhang2077
reviewed
Mar 21, 2025
Collaborator
There was a problem hiding this comment.
@adarshxs Sorry I am late. Thanks for your work, I leave some comments here~
Collaborator
yizhang2077
approved these changes
Mar 21, 2025
Collaborator
|
@adarshxs great work!!! do not rebase with main, let me rerun for you |
Collaborator
|
@adarshxs @zhaochenyang20 @yizhang2077 @mickqian You are great!! |
zhyncs
reviewed
Mar 22, 2025
6 tasks
67 tasks
yhyang201
reviewed
Aug 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Fixes: #3935
Modifications
Add partial rotary embedding support and upgrade to
transformers==4.50.0Also fix Qwen2.5VL which breaks when upgraded to
transformers==4.50.0fromtransformers==4.48.3Also minor fixes to reference_hf.py script
Checklist