[ROCm] Facilitate shfl_xor usage in AMD platform#3664
Closed
yiakwy-xpu-ml-framework-team wants to merge 5 commits intosgl-project:use__shfl_xor_sync_style_reducefrom
Conversation
BBuf
reviewed
Feb 18, 2025
BBuf
reviewed
Feb 18, 2025
BBuf
reviewed
Feb 18, 2025
BBuf
reviewed
Feb 18, 2025
| #ifndef USE_ROCM | ||
| #ifdef USE_ROCM | ||
|
|
||
| #define CHECK_INPUT(x) \ |
Collaborator
There was a problem hiding this comment.
Aten has already defined CHECK_INPUT?
BBuf
reviewed
Feb 18, 2025
BBuf
reviewed
Feb 18, 2025
5 tasks
This was referenced Feb 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Enabe compiling in AMD platform ：
SDK : ROCM 6.3
CHIP ARCH : MI series
Modifications
Checklist