[UnifiedTree]: Support HiCache For DeepSeek_V4#24691
Open
Conversation
Co-authored-by: ispobock <ispobaoke@gmail.com> Co-authored-by: 晟海 <huangtingwei.htw@antgroup.com>
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a sidecar pool mechanism to allow memory pools to share indices from source pools, replacing the previous shared anchor logic. It specifically enables DeepSeek V4 HiCache support by adding new host pool types and stack assembly logic. Feedback highlights a critical bug where the sidecar resolution logic only supports KV as a source, which will cause crashes for DeepSeek V4 state pools that derive from SWA. A redundant enum member in the storage definitions was also noted.
23 tasks
alphabetc1
reviewed
May 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Follow up swa hicache #23391 , this pr implement HiCache for V4 by leveraging UnifiedTree's SWA HiCache capabilities, combined with the Shadow Radix mechanism.
Collaborate with @ispobock @huangtingwei9988
Roadmap: #20415 、
Modifications
Accuracy Tests
Speed Tests and Profiling
Checklist
Review and Merge Process
/tag-and-rerun-ci,/tag-run-ci-label,/rerun-failed-ci