[v0.5.11] Cherry-pick #24234: fix silently-masked cubin download failure; skip prebuilt cubins on aarch64#24567
Closed
ishandhanani wants to merge 1 commit intorelease/v0.5.11from
Closed
Conversation
…bins on aarch64 (#24234) Signed-off-by: misunp <misunp@nvidia.com> Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Contributor
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
Contributor
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Cherry-picks #24234 (
62a4df006onmain) ontorelease/v0.5.11so the Release Docker Runtime Images workflow can produce workinglmsysorg/sglang:v0.5.11-runtimeandv0.5.11-cu130-runtimeimages.The runtime build for v0.5.11 has been failing on every attempt — most recently observed in https://github.com/sgl-project/sglang/actions/runs/25362406194 (build-arm64 failed → x86 + manifests cancelled by fail-fast). The arm64 failure traces back to:
Same root cause #24234 already fixed on
main: the trailing|| truein the editable-install RUN block (intended forfindcleanup) silently swallows the entire&&chain — including[ "$success" = "1" ]— so kernel-download failures on aarch64 produce a runtime image with/root/.cache/sglangmissing, and the runtime stage'sCOPYblows up two stages later with a misleading "not found".The fix isn't in
v0.5.11because #24234 was merged tomainafter the v0.5.11 tag was cut (git merge-base --is-ancestor 62a4df006 v0.5.11→ false). Only the nixl-stub cherry-pick (#24369 → #24382) made it into the tag.Downstream impact: ai-dynamo/dynamo can't bump its container references to
lmsysorg/sglang:v0.5.11-runtimeuntil the runtime workflow can produce them, which gates on this cherry-pick.Modifications
git cherry-pick 62a4df006ontorelease/v0.5.11. No conflicts; the only Dockerfile commit between v0.5.11 and the cherry-pick onrelease/v0.5.11was the existing nixl-stub pick (#24382). Diff matches the upstream PR exactly (1 file, +18 / -9).```
e48812a [docker] Fix silently-masked cubin download failure; skip prebuilt cubins on aarch64 (#24234)
```
Verification
After this lands, either:
v0.5.11tag to the new HEAD ofrelease/v0.5.11and re-trigger Release Docker Runtime Images via the tag push, orv0.5.11.post1tag fromrelease/v0.5.11(cleaner; auto-triggers the workflow), orworkflow_dispatchRelease Docker Runtime Images frommainwithversion=0.5.11(uses main's already-fixed Dockerfile against v0.5.11 Python source — works without retagging sinceactions/checkouthonorsgithub.refand the Dockerfile onlygit clone --branch v\${SGL_VERSION}for the source).I'm taking option 3 to unblock immediately, but cherry-picking here is still the right thing so future tag-triggered builds and any
v0.5.11.post1cut from this branch include the fix.Checklist
Review and Merge Process
docker/.release/v0.5.11.v0.5.11.post1(or move the v0.5.11 tag) to trigger the runtime workflow.