Move FP8 to sglang#2366
Closed
HaiShaw wants to merge 8 commits intosgl-project:mainfrom
Closed
Conversation
Co-authored-by: HAI <hixiao@gmail.com>
zhyncs
reviewed
Dec 5, 2024
Collaborator
zhyncs
left a comment
There was a problem hiding this comment.
Except for vllm.model_executor.layers.quantization, LinearBase, and _custom_ops, everything else needs to be removed. Thanks!
| per_tensor_dequantize, | ||
| requantize_with_max_scale, | ||
| ) | ||
| from vllm.model_executor.parameter import ModelWeightParameter, PerTensorScaleParameter |
Collaborator
Author
There was a problem hiding this comment.
This is still in use, will decouple and migrate later.
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Move FP8 layers definition to SGLang
Modifications
As it is.
Kernels come next.
Checklist