[Spec][Ngram] 8/N: Add support for Per-request Trie mode#22737
Open
kpham-sgl wants to merge 20 commits intosgl-project:mainfrom
Open
[Spec][Ngram] 8/N: Add support for Per-request Trie mode#22737kpham-sgl wants to merge 20 commits intosgl-project:mainfrom
kpham-sgl wants to merge 20 commits intosgl-project:mainfrom
Conversation
Contributor
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
Contributor
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
Collaborator
Author
|
/rerun-test test/registered/unit/spec/test_ngram_corpus.py |
Collaborator
Author
|
/rerun-test test/registered/spec/test_ngram_speculative_decoding.py |
Contributor
|
✅ |
Collaborator
Author
|
/rerun-test test/registered/unit/server_args/test_server_args.py |
Contributor
|
✅ |
Contributor
|
✅ |
11b10fc to
feb80dd
Compare
19 tasks
Collaborator
Author
|
/rerun-test test/registered/spec/test_ngram_speculative_decoding.py |
Contributor
|
✅ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Part of the Ngram series #21052
Following #22538 (hard dependency on #22538, stacking on #22569)
Modifications
speculative_ngram_trie_capacityandspeculative_ngram_trie_capacity_per_request, lowered the per-request default, and updated user-facing docs/help text to match the new memory model.Accuracy Tests
Speed Tests and Profiling
Checklist
Review and Merge Process
/tag-and-rerun-ci,/tag-run-ci-label,/rerun-failed-ci