[diffusion] Add unit test for InputValidationStage.preprocess_condition_image resolution logic#21743
Closed
yeahdongcn wants to merge 1 commit intosgl-project:mainfrom
Closed
Conversation
5 tasks
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a new unit test suite, test_input_validation.py, to verify the image resolution and preprocessing logic within the InputValidationStage. The tests cover aspect ratio handling, area-based scaling, and dimension alignment for various configurations. Feedback focuses on improving the robustness of the tests by replacing loose assertions with exact dimension checks and using positive type assertions. Additionally, a potential logic discrepancy was identified where the tests assume support for user-defined resolutions that may not be fully implemented in the underlying stage logic.
…on_image resolution logic Signed-off-by: Xiaodong Ye <xiaodong.ye@mthreads.com>
058fa29 to
470ef23
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Test
InputValidationStage.preprocess_condition_imageresolution logic introduced in #21390Modifications
Accuracy Tests
Speed Tests and Profiling
Checklist
Review and Merge Process
/tag-and-rerun-ci,/tag-run-ci-label,/rerun-failed-ci