feat: add OpenTelemetry tracing to DiffGenerator#21254
Merged
ishandhanani merged 27 commits intosgl-project:mainfrom Apr 23, 2026
Merged
feat: add OpenTelemetry tracing to DiffGenerator#21254ishandhanani merged 27 commits intosgl-project:mainfrom
ishandhanani merged 27 commits intosgl-project:mainfrom
Conversation
Contributor
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
Collaborator
|
@sufeng-buaa can you take a look? |
Collaborator
ok, I'll review it in the next few days. |
mickqian
reviewed
Mar 26, 2026
sufeng-buaa
reviewed
Mar 30, 2026
sufeng-buaa
reviewed
Mar 30, 2026
sufeng-buaa
reviewed
Apr 1, 2026
mickqian
reviewed
Apr 4, 2026
| @@ -12,15 +12,12 @@ | |||
| os.environ.setdefault("SGLANG_OTLP_EXPORTER_SCHEDULE_DELAY_MILLIS", "50") | |||
Collaborator
There was a problem hiding this comment.
if this is not related to sglang-diffusion, please split into two PRs
Contributor
Author
There was a problem hiding this comment.
This is to reduce duplication in test, and I use it in sglang-diffusion tracing test. To reduce the review cycles, can we do this in one PR?
Collaborator
yhyang201
approved these changes
Apr 7, 2026
Collaborator
|
/tag-and-rerun-ci |
17 tasks
…racing # Conflicts: # python/sglang/multimodal_gen/runtime/managers/scheduler.py # python/sglang/multimodal_gen/runtime/server_args.py
eeeddfd to
3b88cb9
Compare
Contributor
Author
|
/rerun-failed-ci |
Contributor
Author
|
/rerun-failed-ci |
…at/diffgen-otel-tracing
Contributor
Author
|
/rerun-failed-ci |
1 similar comment
Contributor
Author
|
/rerun-failed-ci |
Contributor
Author
|
/rerun-failed-ci |
Collaborator
|
All tests were ran locally. This change does not affect CI |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Enable OpenTelemetry tracing for the diffusion/multimodal generation subsystem (multimodal_gen) to achieve feature parity with the SRT (LLM) runtime, which already has comprehensive OTel instrumentation. This is the initial scaffolding — downstream consumers (e.g., Dynamo) need tracing support in the diffusion path, so we want to land the foundation early. Fine-grained span, rich span attributes (resolution, inference steps, guidance scale, etc.) and additional trace stages will be built on top in follow-up PRs.
Modifications
verification.
Known limitations (planned follow-ups)
Accuracy Tests
N/A — This change adds observability instrumentation only. No model forward code or kernel changes. Tracing is off by default (--enable-trace opt-in) and uses lazy imports, so there is zero impact on the inference
path when disabled.
Benchmarking and Profiling
N/A — When tracing is disabled (default), no tracing code is executed. When enabled, overhead is limited to OTel span creation/export which is asynchronous and batched.
Checklist
Review Process
/tag-run-ci-label,/rerun-failed-ci,/tag-and-rerun-ci