Fix tool_choice stall on multi-call prompts (#17998)#19848
Fix tool_choice stall on multi-call prompts (#17998)#19848AjAnubolu wants to merge 1 commit intosgl-project:mainfrom
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a critical bug that caused the model to stall when processing multi-call prompts with a specified tool_choice. By removing an erroneous "maxItems" constraint from the generated JSON schema, the system can now correctly handle multiple tool calls, preventing infinite loops and improving the reliability of function calling. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request addresses a bug that caused stalls on multi-call prompts when tool_choice specified a particular function. The fix involves removing the maxItems: 1 constraint from the generated JSON schema, which correctly allows for multiple calls to the same function. The associated tests have been updated to verify that the maxItems property is no longer part of the schema. The changes are correct and effectively resolve the issue.
Summary
When
tool_choicespecifies a function name, the JSON schema includedmaxItems: 1which masked the comma token after the first tool call, causing the model to loop on whitespace until max_tokens. Removed the constraint so multiple calls to the same function work correctly.Closes #17998