refactor(e2e_test): fix smg ci e2e test code quality#16664
Conversation
Summary of ChangesHello @slin1237, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on enhancing the code quality, robustness, and maintainability of the end-to-end (e2e) test suite. It introduces several refactorings, including improved error handling for external process execution, safer string decoding, extraction of common logic into helper functions, and the centralization of configuration constants and utility functions. These changes aim to make the e2e tests more reliable, easier to understand, and simpler to modify in the future. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces a series of valuable refactorings and code quality improvements to the e2e test suite. The changes, such as extracting magic numbers to constants, centralizing the health check logic, and adding robust error handling for subprocesses, significantly enhance the maintainability and reliability of the code. However, I've identified one critical issue where the removal of an import will lead to a runtime error. Please see the specific comment for details.
- Extract WorkerInfo construction to helper in gateway.py - Add error handling for subprocess.Popen in benchmarks/conftest.py - Fix silent encoding error risk in gpu_allocator.py - Move MMLU_DATASET_URL to simple_eval_mmlu.py - Extract magic numbers to constants (MAX_RETRY_ATTEMPTS, LOG_SEPARATOR_WIDTH) - Centralize health check in router_manager.py (use process_utils)
…logging - Each prefill worker now gets its own bootstrap port (was incorrectly shared) - Add stdout/stderr logging when genai-bench fails or produces no results - This fixes PD benchmark test failures introduced in e432057
The time module is still used by add_worker and remove_worker methods.
Checklist
Review Process
/tag-run-ci-label,/rerun-failed-ci,/tag-and-rerun-ci) or contact authorized users to do so.