Skip to content

fix: fix regression and unclear pattern#16561

Merged
Kangyan-Zhou merged 10 commits intosgl-project:mainfrom
nanjiangwill:fix/overhead
Jan 17, 2026
Merged

fix: fix regression and unclear pattern#16561
Kangyan-Zhou merged 10 commits intosgl-project:mainfrom
nanjiangwill:fix/overhead

Conversation

@nanjiangwill
Copy link
Copy Markdown
Contributor

Motivation

fix this comment

Modifications

Accuracy Tests

Benchmarking and Profiling

Checklist

Review Process

  1. Ping Merge Oncalls to start the PR flow. See the PR Merge Process.
  2. Get approvals from CODEOWNERS and other reviewers.
  3. Trigger CI tests with comments (/tag-run-ci-label, /rerun-failed-ci, /tag-and-rerun-ci) or contact authorized users to do so.
  4. After green CI and required approvals, ask Merge Oncalls to merge.

@JustinTong0323
Copy link
Copy Markdown
Collaborator

/tag-and-rerun-ci

@github-actions github-actions Bot added the run-ci label Jan 6, 2026
@JustinTong0323
Copy link
Copy Markdown
Collaborator

/tag-and-rerun-ci

@JustinTong0323
Copy link
Copy Markdown
Collaborator

/rerun-failed-ci

@JustinTong0323
Copy link
Copy Markdown
Collaborator

/rerun-failed-ci

1 similar comment
@JustinTong0323
Copy link
Copy Markdown
Collaborator

/rerun-failed-ci

Ensure post_residual_addition is in float32 format.
@JustinTong0323
Copy link
Copy Markdown
Collaborator

/tag-and-rerun-ci

1 similar comment
@JustinTong0323
Copy link
Copy Markdown
Collaborator

/tag-and-rerun-ci

@JustinTong0323
Copy link
Copy Markdown
Collaborator

/rerun-failed-ci

@JustinTong0323
Copy link
Copy Markdown
Collaborator

/rerun-failed-ci

@Kangyan-Zhou Kangyan-Zhou merged commit dd99f81 into sgl-project:main Jan 17, 2026
186 of 202 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants