chore: bump SGLang version to 0.5.5.post1#13000
Conversation
This commit updates the SGLang version across all relevant files:
- benchmark/deepseek_v3/README.md
- docker/Dockerfile
- docker/rocm.Dockerfile
- docs/get_started/install.md
- docs/platforms/amd_gpu.md
- docs/platforms/ascend_npu.md
- python/pyproject.toml
- python/pyproject_cpu.toml
- python/pyproject_other.toml
- python/pyproject_xpu.toml
- python/sglang/version.py
🤖 Generated with GitHub Actions
Summary of ChangesHello @sglang-bot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request systematically updates the SGLang version number to Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request bumps the SGLang version to 0.5.5.post1 across various documentation, configuration, and source files. The changes are straightforward and correctly apply the new version string. I've added one suggestion to improve the consistency of version handling in the Docker build process for better maintainability.
| # docker build --build-arg SGL_BRANCH=v0.5.5.post1 --build-arg GPU_ARCH=gfx942 -t v0.5.5.post1-rocm630-mi30x -f rocm.Dockerfile . | ||
| # docker build --build-arg SGL_BRANCH=v0.5.5.post1 --build-arg GPU_ARCH=gfx942-rocm700 -t v0.5.5.post1-rocm700-mi30x -f rocm.Dockerfile . | ||
| # docker build --build-arg SGL_BRANCH=v0.5.5.post1 --build-arg GPU_ARCH=gfx950 -t v0.5.5.post1-rocm700-mi35x -f rocm.Dockerfile . |
There was a problem hiding this comment.
For consistency with docker/Dockerfile, consider using an SGL_VERSION build argument instead of SGL_BRANCH. The main Dockerfile uses SGL_VERSION (e.g., 0.5.5.post1) and constructs the branch name by prepending v. Adopting this convention here would unify how versions are handled across your Dockerfiles, improving maintainability.
To implement this, you would need to change this usage comment and also adjust the ARG definitions later in this file to derive SGL_BRANCH from SGL_VERSION.
# docker build --build-arg SGL_VERSION=0.5.5.post1 --build-arg GPU_ARCH=gfx942 -t v0.5.5.post1-rocm630-mi30x -f rocm.Dockerfile .
# docker build --build-arg SGL_VERSION=0.5.5.post1 --build-arg GPU_ARCH=gfx942-rocm700 -t v0.5.5.post1-rocm700-mi30x -f rocm.Dockerfile .
# docker build --build-arg SGL_VERSION=0.5.5.post1 --build-arg GPU_ARCH=gfx950 -t v0.5.5.post1-rocm700-mi35x -f rocm.Dockerfile .
Summary
This PR bumps the SGLang version to
0.5.5.post1across all relevant files.Files Updated
🤖 Generated with GitHub Actions