Skip to content

Refactor Triton-kernel MoE runner integration #11795

Merged
ch-wan merged 28 commits intosgl-project:mainfrom
jonahbernard:refactor-triton-kernels-moe-path
Oct 24, 2025
Merged

Refactor Triton-kernel MoE runner integration #11795
ch-wan merged 28 commits intosgl-project:mainfrom
jonahbernard:refactor-triton-kernels-moe-path

Conversation

@jonahbernard
Copy link
Copy Markdown
Contributor

@jonahbernard jonahbernard commented Oct 18, 2025

Motivation

Refactor Triton-kernel MoE runner integration into triton_kernels.py per #8715

Modifications

Plan.md

Accuracy Tests

test/srt/test_triton_fused_moe.py passes on Nvidia B200.

Benchmarking and Profiling

Not relevant as no kernels were modified.

Checklist

Comment thread python/sglang/srt/layers/moe/moe_runner/triton_kernels.py Outdated
Comment thread python/sglang/srt/layers/moe/moe_runner/triton_kernels.py
Comment thread python/sglang/srt/layers/moe/moe_runner/triton_kernels.py Outdated
@jonahbernard jonahbernard requested a review from ch-wan October 20, 2025 02:06
@FlamingoPg FlamingoPg self-assigned this Oct 20, 2025
@ch-wan ch-wan mentioned this pull request Oct 20, 2025
66 tasks
Copy link
Copy Markdown
Collaborator

@ch-wan ch-wan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution. Overall, the code structure and logic look good to me. I left some comments. Also, could you check the errors in CI tests? Thanks.

Comment thread python/sglang/srt/layers/moe/moe_runner/triton_kernels.py Outdated
Comment thread python/sglang/srt/layers/moe/moe_runner/triton_kernels.py Outdated
Comment thread python/sglang/srt/layers/moe/moe_runner/triton_kernels.py Outdated
Comment thread python/sglang/srt/layers/moe/moe_runner/triton_kernels.py Outdated
Comment thread python/sglang/srt/layers/moe/moe_runner/triton_kernels.py Outdated
Comment thread python/sglang/srt/layers/moe/token_dispatcher/base.py Outdated
Comment thread python/sglang/srt/layers/moe/moe_runner/runner.py
Comment thread python/sglang/srt/layers/quantization/unquant.py Outdated
@ch-wan ch-wan self-assigned this Oct 21, 2025
@jonahbernard jonahbernard requested a review from ch-wan October 23, 2025 02:49
Comment thread python/sglang/srt/layers/moe/token_dispatcher/base.py Outdated
@jonahbernard jonahbernard requested a review from ch-wan October 23, 2025 13:46
@ch-wan ch-wan enabled auto-merge (squash) October 24, 2025 01:47
@ch-wan ch-wan disabled auto-merge October 24, 2025 01:47
@ch-wan ch-wan merged commit 62eff37 into sgl-project:main Oct 24, 2025
113 of 140 checks passed
@JustinTong0323
Copy link
Copy Markdown
Collaborator

This PR breaks #12059

@Qiaolin-Yu Qiaolin-Yu mentioned this pull request Oct 24, 2025
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants