chore: bump sgl-kernel version to 0.3.14.post2#11258
chore: bump sgl-kernel version to 0.3.14.post2#11258sglang-bot wants to merge 2 commits intobot_releasefrom
Conversation
This commit updates the sgl-kernel version across all relevant files:
- sgl-kernel/pyproject.toml
- sgl-kernel/pyproject_cpu.toml
- sgl-kernel/pyproject_rocm.toml
- sgl-kernel/python/sgl_kernel/version.py
🤖 Generated with GitHub Actions
Summary of ChangesHello @sglang-bot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request primarily updates the Highlights
Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request bumps the sgl-kernel version and significantly improves the release automation scripts. The new version handling logic in utils.py is robust, well-documented, and now supports pre-release and post-release version specifiers, complete with comprehensive unit tests. The logic for bumping versions is also safer, preventing accidental version downgrades. I have one suggestion for the new commit_and_pr.sh script to improve its efficiency and robustness.
| FILES_LIST=$(git diff --name-only | sed 's/^/- /') | ||
| COMMIT_FILES=$(git diff --name-only | sed 's/^/ - /') |
There was a problem hiding this comment.
To improve efficiency and robustness, you can store the output of git diff --name-only in a variable. This avoids calling the command twice and allows you to add a check to exit gracefully if there are no file changes to commit.
| FILES_LIST=$(git diff --name-only | sed 's/^/- /') | |
| COMMIT_FILES=$(git diff --name-only | sed 's/^/ - /') | |
| CHANGED_FILES=$(git diff --name-only) | |
| if [ -z "$CHANGED_FILES" ]; then | |
| echo "No file changes detected. Nothing to commit." | |
| exit 0 | |
| fi | |
| FILES_LIST=$(echo "$CHANGED_FILES" | sed 's/^/- /') | |
| COMMIT_FILES=$(echo "$CHANGED_FILES" | sed 's/^/ - /') |
Summary
This PR bumps the sgl-kernel version to
0.3.14.post2across all relevant files.Files Updated
🤖 Generated with GitHub Actions