chore: bump SGLang version to 0.5.3rc1#11255
Conversation
This commit updates the SGLang version across all relevant files:
- benchmark/deepseek_v3/README.md
- docker/Dockerfile.rocm
- docs/get_started/install.md
- docs/platforms/amd_gpu.md
- docs/platforms/ascend_npu.md
- python/pyproject.toml
- python/pyproject_other.toml
- python/sglang/version.py
🤖 Generated with GitHub Actions
Summary of ChangesHello @sglang-bot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request primarily focuses on updating the SGLang project's version to Highlights
Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request bumps the SGLang version to 0.5.3rc1. More importantly, it introduces significant improvements to the release automation scripts. The scripts are now more robust, with enhanced version validation that supports rc and post releases, and proper version comparison to prevent accidental downgrades. A new script to automate commits and pull request creation is also added. The changes are well-implemented and will improve the release process. I have one minor suggestion to optimize the new shell script.
| FILES_LIST=$(git diff --name-only | sed 's/^/- /') | ||
| COMMIT_FILES=$(git diff --name-only | sed 's/^/ - /') |
There was a problem hiding this comment.
To avoid executing the same command twice, you can store the output of git diff --name-only in a variable and then use it to generate both FILES_LIST and COMMIT_FILES. This is a minor optimization but improves script efficiency and maintainability.
| FILES_LIST=$(git diff --name-only | sed 's/^/- /') | |
| COMMIT_FILES=$(git diff --name-only | sed 's/^/ - /') | |
| CHANGED_FILES=$(git diff --name-only) | |
| FILES_LIST=$(echo "$CHANGED_FILES" | sed 's/^/- /') | |
| COMMIT_FILES=$(echo "$CHANGED_FILES" | sed 's/^/ - /') |
Summary
This PR bumps the SGLang version to
0.5.3rc1across all relevant files.Files Updated
🤖 Generated with GitHub Actions