Checklist
Describe the bug
Currently we use LoRA name to identify adapters. However, with the introduction of dynamic lora update, this might result in incorrect eviction behavior when the same LoRA name is reused across different adapters, which is not uncommon at production (e.g., when "updating" an existing LoRA).
I realized this case when I was brainstorming with @Fridge003 on radix cache compatibility. I am expecting this to be fixed by #8261. Creating an issue for tracking purposes.
Reproduction
This newly added test would fail on main: test/srt/models/lora/test_lora_eviction.py
Environment
N/A
Checklist
Describe the bug
Currently we use LoRA name to identify adapters. However, with the introduction of dynamic lora update, this might result in incorrect eviction behavior when the same LoRA name is reused across different adapters, which is not uncommon at production (e.g., when "updating" an existing LoRA).
I realized this case when I was brainstorming with @Fridge003 on radix cache compatibility. I am expecting this to be fixed by #8261. Creating an issue for tracking purposes.
Reproduction
This newly added test would fail on main: test/srt/models/lora/test_lora_eviction.py
Environment
N/A