Use ; as classpath separator on Windows#68
Merged
sgammon merged 1 commit intosgammon:mainfrom Aug 29, 2023
Merged
Conversation
Speculative fix for this error seen in CI: ``` Exception in thread "main" java.nio.file.InvalidPathException: Illegal char <:> at index 77: bazel-out/x64_windows-fastbuild/bin/src/main/protobuf/libdeps_proto-speed.jar:bazel-out/x64_windows-fastbuild/bin/external/com_google_protobuf/java/core/libcore.jar:bazel-out/x64_windows-fastbuild/bin/external/com_google_protobuf/java/core/liblite_runtime_only.jar:bazel-out/x64_windows-fastbuild/bin/external/maven/com/google/guava/guava/31.1-jre/guava-31.1-jre.jar:bazel-out/x64_windows-fastbuild/bin/external/maven/com/google/guava/failureaccess/1.0.1/failureaccess-1.0.1.jar:bazel-out/x64_windows-fastbuild/bin/external/maven/com/google/errorprone/error_prone_annotations/2.20.0/processed_error_prone_annotations-2.20.0.jar:bazel-out/x64_windows-fastbuild/bin/external/maven/com/google/errorprone/error_prone_type_annotations/2.20.0/processed_error_prone_type_annotations-2.20.0.jar:bazel-out/x64_windows-fastbuild/bin/external/maven/com/github/stephenc/jcip/jcip-annotations/1.0-1/processed_jcip-annotations-1.0-1.jar:bazel-out/x64_windows-fastbuild/bin/external/maven/com/google/code/findbugs/jsr305/3.0.2/processed_jsr305-3.0.2.jar:third_party/turbine/turbine_direct.jar at java.base@20.0.2/sun.nio.fs.WindowsPathParser.normalize(WindowsPathParser.java:182) at java.base@20.0.2/sun.nio.fs.WindowsPathParser.parse(WindowsPathParser.java:153) at java.base@20.0.2/sun.nio.fs.WindowsPathParser.parse(WindowsPathParser.java:77) at java.base@20.0.2/sun.nio.fs.WindowsPath.parse(WindowsPath.java:92) at java.base@20.0.2/sun.nio.fs.WindowsFileSystem.getPath(WindowsFileSystem.java:232) at java.base@20.0.2/java.nio.file.Path.of(Path.java:148) at org.graalvm.nativeimage.driver/com.oracle.svm.driver.NativeImage.expandAsteriskClassPathElement(NativeImage.java:1795) at org.graalvm.nativeimage.driver/com.oracle.svm.driver.NativeImage.addCustomImageClasspath(NativeImage.java:1774) at org.graalvm.nativeimage.driver/com.oracle.svm.driver.DefaultOptionHandler.processClasspathArgs(DefaultOptionHandler.java:435) at org.graalvm.nativeimage.driver/com.oracle.svm.driver.DefaultOptionHandler.consume(DefaultOptionHandler.java:72) at org.graalvm.nativeimage.driver/com.oracle.svm.driver.NativeImage$NativeImageArgsProcessor.apply(NativeImage.java:1703) at org.graalvm.nativeimage.driver/com.oracle.svm.driver.NativeImage.processNativeImageArgs(NativeImage.java:2016) at org.graalvm.nativeimage.driver/com.oracle.svm.driver.NativeImage.completeImageBuild(NativeImage.java:945) at org.graalvm.nativeimage.driver/com.oracle.svm.driver.NativeImage.build(NativeImage.java:1592) at org.graalvm.nativeimage.driver/com.oracle.svm.driver.NativeImage.performBuild(NativeImage.java:1557) at org.graalvm.nativeimage.driver/com.oracle.svm.driver.NativeImage.main(NativeImage.java:1531) ```
sgammon
approved these changes
Aug 29, 2023
Owner
|
@fmeum thanks for the contribution, i'll force push a commit with a signature and to fix commitcheck (this project uses conventional commits, but it's mostly cosmetic). |
|
Kudos, SonarCloud Quality Gate passed!
|
Owner
|
@fmeum nevermind, forgot i can't push to your fork. I'm okay with foregoing the signature on this one. Thanks again. Will get back to you about BCR. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for this error seen in CI: