Conversation
|
Build's failing. |
LibreSSL 2.9.1 added generic DTLS methods. While here, bump CircleCI.
|
Working on this has actually exposed certain items present since LibreSSL 2.7.1 that the cfgs logic don't currently account for. Hold tight… |
|
Don't worry about the failing macOS builds - they're busted due to a rustup.rs issue that should be fixed tomorrow. |
|
I figured the macOS builds failing was external, so I've disregarded them. Meanwhile, I'm not quite sure what's causing two of the LibreSSL 2.9.1 tests to panic. I will come back to this once all my FreeBSD ports finish building (from an ABI bump), as how we build rust itself (completely frozen crates) requires this crate (for cargo). |
|
I'm currently trying to get this crate to work with OpenBSD current and LibreSSL 2.9.1, but two tests fail: Seems that LibreSSL is not compiled with SRTP support or there is something wrong with rust-openssl configuration on OpenBSD. |
|
There doesn't appear to be anything obvious in the 2.9.1 release notes, so you may have to do some investigation. Maybe some struct layouts changed or something? |
|
Cc @botovq. Theo, can you please take a look at this? |
|
@mbelop: Thanks for pointing this out to me.
This revealed a bug we introduced into LibreSSL while refactoring the
extensions parsing. Due to this bug, the server hello no longer includes
use_srtp, so negotiation of an srtp profile fails, and the tests panic
in this line on the client side:
let srtp_profile = stream.ssl().selected_srtp_profile().unwrap();
This will be fixed in LibreSSL 2.9.2.
|
|
Great, thanks for tracking that down! We'll just ignore those tests on 2.9.1 then. |
SRTP is broken in that release!
- While here add patches from [1] for LibreSSL 2.9.1 support [1] rust-openssl/rust-openssl#1097 Changes: https://blog.rust-lang.org/2019/05/13/Security-advisory.html Changes: https://blog.rust-lang.org/2019/05/14/Rust-1.34.2.html PR: 237495 [1] Security: 37528379-76a8-11e9-a4fd-00012e582166 git-svn-id: svn+ssh://svn.freebsd.org/ports/head@501679 35697150-7ecd-e111-bb59-0022644237b5
- While here add patches from [1] for LibreSSL 2.9.1 support [1] rust-openssl/rust-openssl#1097 Changes: https://blog.rust-lang.org/2019/05/13/Security-advisory.html Changes: https://blog.rust-lang.org/2019/05/14/Rust-1.34.2.html PR: 237495 [1] Security: 37528379-76a8-11e9-a4fd-00012e582166
- While here add patches from [1] for LibreSSL 2.9.1 support [1] rust-openssl/rust-openssl#1097 Changes: https://blog.rust-lang.org/2019/05/13/Security-advisory.html Changes: https://blog.rust-lang.org/2019/05/14/Rust-1.34.2.html PR: 237495 [1] Security: 37528379-76a8-11e9-a4fd-00012e582166 git-svn-id: svn+ssh://svn.freebsd.org/ports/head@501679 35697150-7ecd-e111-bb59-0022644237b5
- While here add patches from [1] for LibreSSL 2.9.1 support [1] rust-openssl/rust-openssl#1097 Changes: https://blog.rust-lang.org/2019/05/13/Security-advisory.html Changes: https://blog.rust-lang.org/2019/05/14/Rust-1.34.2.html PR: 237495 [1] Security: 37528379-76a8-11e9-a4fd-00012e582166 git-svn-id: svn+ssh://svn.freebsd.org/ports/head@501679 35697150-7ecd-e111-bb59-0022644237b5
LibreSSL 2.9.1 added generic DTLS methods, among other things: libressl/openbsd@ff8fdf5