Fix varint/LEB128 decoding for values > 16383#113
Merged
Conversation
The shift calculation was incorrect. The old formula only worked by accident for 1-2 byte varints. For 3+ byte values, it produced garbage results. The additional tests fail without the fix. Per the protobuf encoding spec [1] and LEB128 spec [2]: - Each byte contributes 7 bits of payload - Bytes are ordered LSB first - The MSB is a continuation flag [1] https://protobuf.dev/programming-guides/encoding/ [2] https://en.wikipedia.org/wiki/LEB128
Owner
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The shift calculation was incorrect. The old formula only worked by accident for 1-2 byte varints. For 3+ byte values, it produced garbage results. The additional tests fail without the fix.
Per the protobuf encoding spec [1] and LEB128 spec [2]:
[1] https://protobuf.dev/programming-guides/encoding/
[2] https://en.wikipedia.org/wiki/LEB128