Capture: refined and clarified the associated TODOs

kvark · kvark · commit aeb2c6024aa0 · 2018-01-16T16:16:05.000-05:00
diff --git a/webrender/src/render_backend.rs b/webrender/src/render_backend.rs
@@ -858,6 +858,8 @@ impl RenderBackend {
                     &mut profile_counters.resources,
                 );
                 //TODO: write down full `RenderedDocument`?
+                // it has `pipeline_epoch_map` and `layers_bouncing_back`,
+                // which may capture necessary details for some cases.
                 let file_name = format!("frame-{}-{}", (id.0).0, id.1);
                 config.serialize(&rendered_document.frame, file_name);
             }
diff --git a/webrender/src/renderer.rs b/webrender/src/renderer.rs
@@ -4843,8 +4843,6 @@ impl Renderer {
 
         if !deferred_images.is_empty() {
             info!("saving external images");
-            //TODO: add a switch to check `self.texture_resolver.external_images`
-            // instead of locking with the actual handler.
             let handler = self.external_image_handler
                 .as_mut()
                 .expect("Unable to lock the external image handler!");
@@ -4936,9 +4934,7 @@ impl Renderer {
                 rows.clear();
                 cpu_blocks.clear();
             }
-            CacheBus::Scatter { ref mut count, .. } => {
-                *count = 0; //TODO?
-            }
+            CacheBus::Scatter { .. } => {}
         }
 
         info!("loading external images");
@@ -4949,12 +4945,13 @@ impl Renderer {
 
         for ExternalCaptureImage { short_path, external, descriptor } in renderer.external_images {
             let target = get_external_image_target(external.image_type).unwrap();
-            let layer_count = 1; //TODO?
+            //TODO: provide a way to query both the layer count and the filter from external images
+            let (layer_count, filter) = (1, TextureFilter::Linear);
             let plain = PlainTexture {
                 data: short_path,
                 size: (descriptor.width, descriptor.height, layer_count),
                 format: descriptor.format,
-                filter: TextureFilter::Linear, //TODO?
+                filter,
                 render_target: None,
             };
 
diff --git a/webrender/src/resource_cache.rs b/webrender/src/resource_cache.rs
@@ -1082,7 +1082,8 @@ impl ResourceCache {
                         Entry::Vacant(e) => e,
                     };
 
-                    //TODO: option to save as PNG
+                    //TODO: option to save as PNG:
+                    // https://github.com/servo/webrender/issues/2234
                     let file_name = format!("{}.raw", image_id);
                     let short_path = format!("images/{}", file_name);
                     fs::File::create(path_images.join(file_name))
@@ -1095,7 +1096,9 @@ impl ResourceCache {
                     assert_eq!(template.tiling, None);
                     let request = BlobImageRequest {
                         key,
-                        tile: None, //TODO: tiled blob images
+                        //TODO: support tiled blob images
+                        // https://github.com/servo/webrender/issues/2236
+                        tile: None,
                     };
 
                     let renderer = self.blob_image_renderer.as_mut().unwrap();
@@ -1245,7 +1248,9 @@ impl ResourceCache {
         use std::io::Read;
 
         info!("loading resource cache");
-        //TODO: pre-load the raw map
+        //TODO: instead of filling the local path to Arc<data> map as we process
+        // each of the resource types, we could go through all of the local paths
+        // and fill out the map as the first step.
         let mut raw_map = FastHashMap::<String, Arc<Vec<u8>>>::default();
 
         match caches {
@@ -1349,7 +1354,6 @@ impl ResourceCache {
                     e.get().clone()
                 }
                 Entry::Vacant(e) => {
-                    //TODO: consider merging the code path with font loading
                     let mut buffer = Vec::new();
                     File::open(root.join(e.key()))
                         .expect(&format!("Unable to open {}", e.key()))

Original file line number	Diff line number	Diff line change
`@@ -858,6 +858,8 @@ impl RenderBackend {`
`858`	`858`	`&mut profile_counters.resources,`
`859`	`859`	`);`
`860`	`860`	//TODO: write down full `RenderedDocument`?
	`861`	+ // it has `pipeline_epoch_map` and `layers_bouncing_back`,
	`862`	`+ // which may capture necessary details for some cases.`
`861`	`863`	`let file_name = format!("frame-{}-{}", (id.0).0, id.1);`
`862`	`864`	`config.serialize(&rendered_document.frame, file_name);`
`863`	`865`	`}`