Clean up API in preparation for future 2.0 release#15
Merged
Conversation
Change the names of these methods to be more consistent with other Rust libraries. The old names are still available but marked as deprecated. They will be removed in the next major release.
These methods are not useful for external code, and will be made private in the next major release.
b0b7f55 to
f77340e
Compare
Member
|
What's the purpose of the 1.1.0 change? Otherwise this looks fine. |
Collaborator
Author
I'd like to publish a release with this change, and I wanted to remember to bump the minor version because this adds new public methods. |
Member
|
Oops, I definitely misread the change. Looks good! |
Collaborator
Author
|
Note: I pushed a quick fix to revert the deprecation of I'd still like to remove these methods in a future release, but it will have to wait. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change the names of a couple of methods to be consistent with other Rust libraries.
num_entriestolen.evict_alltoclear.The old names are still available but marked as deprecated. They will be removed in the next major release.
Also mark
frontandfront_mutas deprecated. These methods are not useful for external code, and will be made private in the next major release.