You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I'm not sure that every test needs to be a quickcheck test, though. For example, the new evict_all test doesn't really add any new coverage compared to the old one, since it only randomizes the stored values, which has no effect on the uluru code being tested.
For simplicity, could you keep the existing non-quickcheck tests, and use quickcheck only in new tests that benefit from the randomization?
I'm not sure that every test needs to be a quickcheck test, though. For example, the new evict_all test doesn't really add any new coverage compared to the old one, since it only randomizes the stored values, which has no effect on the uluru code being tested.
For simplicity, could you keep the existing non-quickcheck tests, and use quickcheck only in new tests that benefit from the randomization?
Indeed, that makes sense to me. I will update the PR to only use quickcheck for new tests! Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current test cases are great enough though, I wonder if it's good to introduce
quickcheckto have more randomness in the test cases.Also, I added tests for
front,findandtouchin this PR.(btw, I just noticed there's no CI for this repo 👀 maybe it's good to use GitHub Actions or Travis CI?)