webgl: Update stable test expectations to close intermittent issue#44344
Merged
yezhizhen merged 1 commit intoservo:mainfrom Apr 19, 2026
Merged
webgl: Update stable test expectations to close intermittent issue#44344yezhizhen merged 1 commit intoservo:mainfrom
yezhizhen merged 1 commit intoservo:mainfrom
Conversation
Since 5634eab, tex-3d-size-limit.html is not crashing anymore, and even though I updated the test expectations and the test is consistently passing locally at that commit, it's now failing some tests that should have failed since the beginning (since there's no associated check in the code). I'm not sure why things seem to work with the previous test expectations update and will follow-up, but in the meanwhile let's update them. With this, things seem to be pretty good: $ ./mach test-wpt --dev tests/wpt/webgl/tests/conformance2/textures/misc/tex-3d-size-limit.html --repeat 1000 [...] web-platform-test ~~~~~~~~~~~~~~~~~ Ran 92000 checks (91000 subtests, 1000 tests) Expected results: 92000 Unexpected results: 0 OK Signed-off-by: Simon Martin <simon@nasilyan.com>
Contributor
Author
|
linux-wpt try run: https://github.com/simartin/servo/actions/runs/24624726055 |
yezhizhen
approved these changes
Apr 19, 2026
Member
Contributor
Author
|
It seems we can flip between the expectations priori to this PR and that after it - I start to regret fixing the crash that was hiding everything ;-) I'll look into this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since 5634eab, tex-3d-size-limit.html is not crashing anymore, and even though I updated the test expectations and the test is consistently passing locally at that commit, it's now failing some tests that should have failed since the beginning (since there's no associated check in the code).
I'm not sure why things seem to work with the previous test expectations update and will follow-up, but in the meanwhile let's update them.
With this, things seem to be pretty good:
Testing: Test seems to pass consistently with the updated expectations.
Fixes: #44280