webgl: check TexImage3D's input data length#44270
Merged
mrobinson merged 1 commit intoservo:mainfrom Apr 16, 2026
Merged
Conversation
Contributor
Author
|
Manual try linux-wpt => https://github.com/simartin/servo/actions/runs/24503740475 |
tex-3d-size-limit.html currently crashes because we don't check that the input data is large enough, and happily access memory that's not ours if it's not. The referenced ticket comes from the fact that we don't systematically detect a crash (which makes sense if we're (un)lucky), and this patch eradicates the crash altogether by checking the input buffer size. The size computation is a (partial) port of WPT's computeImageSizes3D JS function. Fixes: servo#42881 Testing: Some expected failures in wpt/webgl can be removed, including a crash. Signed-off-by: Simon Martin <simon@nasilyan.com>
mrobinson
approved these changes
Apr 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tex-3d-size-limit.html currently crashes because we don't check that the input data is large enough, and happily access memory that's not ours if it's not.
The referenced ticket comes from the fact that we don't systematically detect a crash (which makes sense if we're (un)lucky), and this patch eradicates the crash altogether by checking the input buffer size. The size computation is a (partial) port of WPT's computeImageSizes3D JS function.
Fixes: #42881
Testing: Some expected failures in wpt/webgl can be removed, including a crash.