servoshell: Do not forward key events to egui when no widget is focused#41314
Merged
atbrakhi merged 1 commit intoservo:mainfrom Dec 16, 2025
Merged
Conversation
When no egui widget is focused, the `WebView` itself is effectively focused, so we should not forward keyboard events to egui. This change does that as well as switch the key processing function in `Gui` to use an early return approach for all events that should go immediately to the `WebView` or are otherwise consumed. Eventually, key events that are not consumed by the `WebView` should be forwarded back to `egui`, so that the user can, for instance, tab out of the `WebView`, but this requires having a version of winit with: rust-windowing/winit#4026 Signed-off-by: Martin Robinson <mrobinson@igalia.com>
Taym95
approved these changes
Dec 16, 2025
atbrakhi
approved these changes
Dec 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When no egui widget is focused, the
WebViewitself is effectivelyfocused, so we should not forward keyboard events to egui. This change
does that as well as switch the key processing function in
Guito usean early return approach for all events that should go immediately to
the
WebViewor are otherwise consumed.Eventually, key events that are not consumed by the
WebViewshould beforwarded back to
egui, so that the user can, for instance, tab out ofthe
WebView, but this requires having a version of winit with:rust-windowing/winit#4026
Testing: This level of servoshell is untested unfortunately so no tests are added.
Fixes: #41307.