Skip to content

Conversation

@jschwe
Copy link
Member

@jschwe jschwe commented Dec 1, 2025

The script seems to get sometimes stuck, so add a timeout that prevents needing to wait until the default timeout is hit.
The timeouts might be related to the script change from #40798.

Testing: Not needed.

The script seems to get stuck sometimes, so add a timeout that
prevents needing to wait until the default timeout is hit.

Signed-off-by: Jonathan Schwender <schwenderjonathan@gmail.com>
@jschwe jschwe requested a review from sagudev as a code owner December 1, 2025 19:38
@servo-highfive servo-highfive added the S-awaiting-review There is new code that needs to be reviewed. label Dec 1, 2025
Copy link
Member

@sagudev sagudev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's land this, but we should probably fix this for real in py script somehow.

@servo-highfive servo-highfive removed the S-awaiting-review There is new code that needs to be reviewed. label Dec 1, 2025
@jschwe jschwe added this pull request to the merge queue Dec 1, 2025
@servo-highfive servo-highfive added the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Dec 1, 2025
@jschwe
Copy link
Member Author

jschwe commented Dec 1, 2025

Let's land this, but we should probably fix this for real in py script somehow.

Oh definitely. I'll have a look tomorrow to see what's going on.

Merged via the queue into servo:main with commit 57346db Dec 1, 2025
32 checks passed
@jschwe jschwe deleted the ohos-timeout branch December 1, 2025 21:59
@servo-highfive servo-highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Dec 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants