Skip to content

Remove unused ipc-channel dependency in layout and background_hang_monitor #40990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
yezhizhen merged 3 commits into from
Dec 2, 2025
Merged

Remove unused ipc-channel dependency in layout and background_hang_monitor #40990

yezhizhen merged 3 commits into from
Dec 2, 2025

Conversation

@Narfinger
Copy link
Contributor

@Narfinger Narfinger commented Dec 1, 2025 •
edited by mrobinson
Loading

layout and background_hang_monitor do not need ipc-channel anymore.

Testing: It compiles.

@Narfinger
removed unused dependency
9cc05fe 
Signed-off-by: Narfinger <Narfinger@users.noreply.github.com>
@servo-highfive servo-highfive added the S-awaiting-review There is new code that needs to be reviewed. label Dec 1, 2025
@Narfinger Narfinger marked this pull request as draft December 1, 2025 17:19
@Narfinger
background hang monitor does not need ipc channel.
160b283 
Signed-off-by: Narfinger <Narfinger@users.noreply.github.com>
@Narfinger Narfinger changed the title Lint: Removed unused dependency in layout Lint: Removed unused dependency in layout and bhm Dec 1, 2025
@Narfinger Narfinger marked this pull request as ready for review December 1, 2025 17:22
@Narfinger Narfinger force-pushed the generic-channel-layout branch from cf13f92 to 160b283 Compare December 1, 2025 17:22
@mrobinson mrobinson changed the title Lint: Removed unused dependency in layout and bhm Remove unused ipc-channel dependency layout and background_hang_monitor Dec 1, 2025
@Narfinger
shared does not need it either
1b42d34 
Signed-off-by: Narfinger <Narfinger@users.noreply.github.com>
@yezhizhen yezhizhen changed the title Remove unused ipc-channel dependency layout and background_hang_monitor Remove unused ipc-channel dependency in layout and background_hang_monitor Dec 2, 2025
@servo-highfive servo-highfive removed the S-awaiting-review There is new code that needs to be reviewed. label Dec 2, 2025
@yezhizhen yezhizhen added this pull request to the merge queue Dec 2, 2025
@servo-highfive servo-highfive added the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Dec 2, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 2, 2025
@servo-highfive servo-highfive added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Dec 2, 2025
@yezhizhen yezhizhen added this pull request to the merge queue Dec 2, 2025
@servo-highfive servo-highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-tests-failed The changes caused existing tests to fail. labels Dec 2, 2025
Merged via the queue into servo:main with commit 8809c1e Dec 2, 2025
36 checks passed
@servo-highfive servo-highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Dec 2, 2025
@Narfinger Narfinger deleted the generic-channel-layout branch December 2, 2025 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Loirooriol Loirooriol Loirooriol approved these changes

@yezhizhen yezhizhen yezhizhen approved these changes

@mrobinson mrobinson Awaiting requested review from mrobinson mrobinson is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Narfinger @Loirooriol @yezhizhen @servo-highfive