script: Reverse retargeting algorithm for ShadowRoot.element[s]FromPoint. #40975
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…int. Signed-off-by: Josh Matthews <josh@joshmatthews.net>
jdm
commented
Dec 1, 2025
| [document.elementFromPoint and shadowRoot.elementFromPoint must return the element assigned to a slot when hit-tested text node under an element is assigned to a slot in the shadow tree and the shadow host of the slot has display: inline-block] | ||
| expected: FAIL | ||
|
|
||
| [document.elementFromPoint must return the shadow host of the hit-tested element under a shadow root and shadowRoot.elementFromPoint must return the element parent of the hit-tested text node under the point when the shadow host has display: inline] |
Member
Author
There was a problem hiding this comment.
The remaining failures in this file are caused by #40973.
yezhizhen
approved these changes
Dec 1, 2025
Member
Author
|
No, that requires a fix for #40973, which does not involve calling the method on a ShadowRoot. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implementation is not actually specified (see #40973 and w3c/csswg-drafts#556), but the implementation that we have is backwards. Other retargeting uses that describe "retarget something against another thing" map to
something.retarget(another_thing), but what the current code was doing for element[s]FromPoint was the equivalent of "retarget this against each element", which is obviously wrong.Testing: Newly-passing tests.