Skip to content

servoshell: Always exit via RunningAppState::schedule_exit #40953

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mrobinson merged 1 commit into from
Nov 29, 2025
Merged

servoshell: Always exit via RunningAppState::schedule_exit #40953

mrobinson merged 1 commit into from
Nov 29, 2025

Conversation

@mrobinson
Copy link
Member

@mrobinson mrobinson commented Nov 29, 2025 •
edited by jschwe
Loading

This prevents crashes when exiting servoshell in different situations.
For instance, this fixes a crash when running WPT tests on some systems.

Testing: This fixes an issue when running WPT tests locally.

@mrobinson
servoshell: Always exit via RunningAppState::schedule_exit
725b10a 
This prevents crashes when existing servoshell in different situtions.
For instance, this fixes a crash when running WPT tests on some systems.

Signed-off-by: Martin Robinson <mrobinson@igalia.com>
@mrobinson mrobinson requested a review from jschwe as a code owner November 29, 2025 11:18
@servo-highfive servo-highfive added the S-awaiting-review There is new code that needs to be reviewed. label Nov 29, 2025
jschwe
jschwe approved these changes Nov 29, 2025
View reviewed changes
Copy link
Member

@jschwe jschwe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I edited the PR description to fix some typos.

@servo-highfive servo-highfive removed the S-awaiting-review There is new code that needs to be reviewed. label Nov 29, 2025
@mrobinson
Copy link
Member Author

mrobinson commented Nov 29, 2025

I edited the PR description to fix some typos.

Thank you!

@mrobinson mrobinson added this pull request to the merge queue Nov 29, 2025
@servo-highfive servo-highfive added the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Nov 29, 2025
Merged via the queue into servo:main with commit 8c24a80 Nov 29, 2025
33 checks passed
@mrobinson mrobinson deleted the exit-servoshell-cleanly branch November 29, 2025 12:03
@servo-highfive servo-highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Nov 29, 2025
@yezhizhen
Copy link
Member

yezhizhen commented Dec 1, 2025 •
edited
Loading

After this PR, the wpt runner always kills the servo instead of normally shutting down, after max retries. This slows things down.

@tharkum
Copy link
Contributor

tharkum commented Dec 1, 2025

This PR is fixing the following CRASH on test exit?

 0:03.68 pid:515064 mozilla::detail::MutexImpl::~MutexImpl: pthread_mutex_destroy failed: Device or resource busy
 0:03.68 pid:515064 Caught signal 11 in thread "main"
 0:03.70 pid:515064    0: servoshell::backtrace::print
 0:03.70 pid:515064    1: servoshell::crash_handler::install::handler
 0:03.75 pid:515064    2: <unknown>
 0:03.75 pid:515064    3: _ZN7mozilla6detail9MutexImplD2Ev
 0:03.75 pid:515064    4: __run_exit_handlers
 0:03.75 pid:515064              at ./stdlib/exit.c:113:8
 0:03.75 pid:515064    5: __GI_exit
 0:03.75 pid:515064              at ./stdlib/exit.c:143:3
 0:03.75 pid:515064    6: __libc_start_call_main
 0:03.75 pid:515064              at ./csu/../sysdeps/nptl/libc_start_call_main.h:74:3
 0:03.75 pid:515064    7: __libc_start_main_impl
 0:03.75 pid:515064              at ./csu/../csu/libc-start.c:392:3
 0:03.75 pid:515064    8: _start

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jschwe jschwe jschwe approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@mrobinson @yezhizhen @tharkum @jschwe @servo-highfive