Skip to content

Conversation

@Narfinger
Copy link
Contributor

Servo can now use a http proxy to connect to the internet. This currently only supports using all connections through the proxy.

This uses the already used hyper_util crate which had the functionality in it already.
We also switch from tower_service to tower with only util feature flag. This might increase the binary size slightly.

Testing: Tested on a local machine which is behind a proxy with and without the flag and it works correctly.

@Narfinger
Copy link
Contributor Author

If somebody has a better idea for the TunnelErrorMasker I would love to hear it but this seems to be the only way I could make it work.

@Narfinger Narfinger marked this pull request as ready for review November 28, 2025 16:35
@servo-highfive servo-highfive added the S-awaiting-review There is new code that needs to be reviewed. label Nov 28, 2025
Copy link
Member

@yezhizhen yezhizhen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would be a life safer when I'm using Servo behind NSA network.

Perhaps someone else should take a look at this.

@servo-highfive servo-highfive added S-needs-rebase There are merge conflict errors. and removed S-awaiting-review There is new code that needs to be reviewed. labels Dec 1, 2025
Copy link
Member

@jdm jdm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great!

Signed-off-by: Narfinger <Narfinger@users.noreply.github.com>
Signed-off-by: Narfinger <Narfinger@users.noreply.github.com>
@servo-highfive servo-highfive added S-awaiting-review There is new code that needs to be reviewed. and removed S-needs-rebase There are merge conflict errors. labels Dec 1, 2025
@jdm jdm added this pull request to the merge queue Dec 1, 2025
@servo-highfive servo-highfive added the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Dec 1, 2025
Merged via the queue into servo:main with commit 22ce2e0 Dec 1, 2025
32 checks passed
@servo-highfive servo-highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Dec 1, 2025
@Narfinger Narfinger deleted the http-proxy-real branch December 1, 2025 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-awaiting-review There is new code that needs to be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants