script: Implement import key operation of Argon2 #40932
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Start adding Argon2 support to WebCrypto API. This patch implements import key operation of Argon2. Testing: - Pass some WPT tests that were expected to fail. - Some new FAIL expectations are added to `argon2.tentative.https.any.js.ini`, which require the not-yet-implemented derive bits operation of Argon2. These tests were skipped by WPT when the import key operation of Argon2 had not been implemented at the time. Fixes: Part of 40687 Signed-off-by: Kingsley Yung <kingsley@kkoyung.dev>
jdm
approved these changes
Nov 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Start adding Argon2 support to WebCrypto API.
This patch implements import key operation of Argon2.
Testing:
argon2.tentative.https.any.js.ini, which require the not-yet-implemented derive bits operation of Argon2. These tests were skipped by WPT when the import key operation of Argon2 had not been implemented at the time.Fixes: Part of #40687