servoshell: Add proper labels to UI elements #40925
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukewarlow
commented
Nov 27, 2025
|
|
||
| ui.allocate_ui_with_layout( | ||
| ui.available_size(), | ||
| egui::Layout::right_to_left(egui::Align::Center), |
Contributor
Author
There was a problem hiding this comment.
I know this is used so the prefs button can be after the search input without needing to size the input carefully, but it currently leads to the visual order and the focus order not matching.
The various UI controls in servo are now announced nicely to screen readers rather than e.g. "Radioactive button". Signed-off-by: Luke Warlow <lwarlow@igalia.com>
b5aa96a to
87b5b47
Compare
mrobinson
approved these changes
Nov 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The various UI controls in servo are now announced nicely to screen readers rather than e.g. "Radioactive button".
Fixes: #38130