script_bindings: Disallow manual Drop implementations for DOM interfaces. #40919
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrobinson
approved these changes
Nov 27, 2025
Member
mrobinson
left a comment
There was a problem hiding this comment.
Interesting. It seems that this is mainly an issue for WebGPU, WebGL, and a single cookie DOM object.
Member
Author
|
Yeah, @willypuzzle has already fixed a bunch of other interfaces, but it mainly affects interfaces that gave some kind of registration/unregistration pattern. |
…entations. Signed-off-by: Josh Matthews <josh@joshmatthews.net>
bd76d23 to
8c1f6a0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements the solution from #26488 that prevents implementing Drop manually for DOM interfaces, which is very easy to write in a way that can cause memory safety errors during JS runtime teardown. Since we have a bunch of pre-existing implementations that we are working on removing, this PR adds an opt-out mechanism that those interfaces use.
Testing: Compile-time code generation; not possible to test.
Fixes: part of #26488