-
-
Notifications
You must be signed in to change notification settings - Fork 3.4k
html: Add new media tracks when receiving the initial media metadata event
#40917
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
TimvdLippe
merged 1 commit into
servo:main
from
tharkum:html-media-add-media-tracks-initial-metadata-event
Nov 27, 2025
Merged
html: Add new media tracks when receiving the initial media metadata event
#40917
TimvdLippe
merged 1 commit into
servo:main
from
tharkum:html-media-add-media-tracks-initial-metadata-event
Nov 27, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…` event The new audio/video tracks should be added to the media element from the initial `metadata` event from the media engine because there are possibility of the multiple `metadata` events without any associated `media track` state changes and previosly the application added new tracks into lists unconditionally. The registered issue to handle possible dynamic `media track` state changes from the media engine gracefully. servo/media#473 Testing: Improvements in the following tests - html/semantics/embedded-content/the-video-element/video_size_preserved_after_ended.html Fixes: servo#32623 Signed-off-by: Andrei Volykhin <andrei.volykhin@gmail.com>
|
🔨 Triggering try run (#19727968435) for Linux (WPT) |
|
Test results for linux-wpt from try job (#19727968435): Flaky unexpected result (37)
Stable unexpected results that are known to be intermittent (24)
|
|
✨ Try run (#19727968435) succeeded. |
TimvdLippe
approved these changes
Nov 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new audio/video tracks should be added to the media element from the initial
metadataevent from the media engine because there are possibility of the multiplemetadataevents without any associatedmedia trackstate changes and previously the application added new tracks into lists unconditionally.The registered issue to handle possible dynamic
media trackstate changes from the media engine gracefully.servo/media#473
Testing: Improvements in the following tests
Fixes: #32623