fix RefCell already borrowed panic in readablestream #40911
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
df0a083 to
83e03a6
Compare
yezhizhen
approved these changes
Nov 27, 2025
Member
yezhizhen
left a comment
There was a problem hiding this comment.
Thanks! Only lint and one redundant comment.
83e03a6 to
a10fc86
Compare
Signed-off-by: Taym Haddadi <haddadi.taym@gmail.com>
a10fc86 to
ecaaa95
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes an intermittent RefCell already borrowed panic in the ReadableStream implementation by tightening the borrow scope of ReadableStream::reader in the error and cancel.
Testing: super hard to make crash test for this.
Fixes: #40894