html: Update the media player state without delays #40898
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e22f1c6 to
d7e510b
Compare
|
🔨 Triggering try run (#19699271335) for Linux (WPT) |
|
Test results for linux-wpt from try job (#19699271335): Flaky unexpected result (38)
Stable unexpected results that are known to be intermittent (29)
|
|
✨ Try run (#19699271335) succeeded. |
Currently the sequence order of the DOM method calls and the media player API calls is mismatched because some media player operations (*) posted to media task with delayed processing (while should be processed immediately). - DOM (script): pause -> seek -> play - Media: seek -> pause* -> play* Also the associated queued media events can be fired and processed by script somehow (e.g. by calling `seek` in event listener handler) even before the calling of the media player `play/pause` API. To handle it the application will try to update media state (by calling media player API) on each DOM `play, pause` method calls and on some `ready state` changes with checking if the media element can be potencially playing. See https://html.spec.whatwg.org/multipage/#potentially-playing Testing: No expected testing results changes because there are unexpected `seek completion` signals from the media engine with invalid time positions which are affecting passing test score (by masking false positive results). https://gitlab.freedesktop.org/gstreamer/gstreamer/-/issues/4762 Signed-off-by: Andrei Volykhin <andrei.volykhin@gmail.com>
d7e510b to
14ff8f0
Compare
TimvdLippe
approved these changes
Nov 27, 2025
Contributor
TimvdLippe
left a comment
There was a problem hiding this comment.
I would have expected some WPT tests to start passing, or at least some test impact. I guess it's good that things are stable, so approving as such. Do make sure that, if there is user visible impact, we cover such cases with tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the sequence order of the DOM method calls and the media player API calls is mismatched because some media player operations (*) posted to media task with delayed processing (while should be processed immediately).
Also the associated queued media events can be fired and processed by script somehow (e.g. by calling
seekin event listener handler) even before the calling of the media playerplay/pauseAPI.To handle it the application will try to update media state (by calling media player API) on each DOM
play, pausemethod calls and on someready statechanges with checking if the media element can be potencially playing.See https://html.spec.whatwg.org/multipage/#potentially-playing
Testing: No expected testing results changes because there are unexpected
seek completionsignals from the media engine with invalid time positions which are affecting passing test score (by masking false positive results).https://gitlab.freedesktop.org/gstreamer/gstreamer/-/issues/4762