Skip to content

Conversation

@Narfinger
Copy link
Contributor

@Narfinger Narfinger commented Nov 25, 2025

New versions of the OS changed the hitrace tracing format. This PR updates the hitrace-bench version that supports both log formats.

We also update the check if servo crashed as the bundle name is not anymore included in the traces.

Testing: Tested on CI here: https://github.com/Narfinger/servo/actions/runs/19677035300

@Narfinger Narfinger force-pushed the trying-other-version branch from 1da49bf to 8be9403 Compare November 25, 2025 17:21
@jschwe
Copy link
Member

jschwe commented Nov 25, 2025

Is this ready for review / merge, or do you still need to check something?

Signed-off-by: Narfinger <Narfinger@users.noreply.github.com>
@Narfinger Narfinger force-pushed the trying-other-version branch from 1d4fdb8 to 49c2e80 Compare November 26, 2025 08:41
@Narfinger Narfinger marked this pull request as ready for review November 26, 2025 08:41
@Narfinger Narfinger requested a review from sagudev as a code owner November 26, 2025 08:41
@servo-highfive servo-highfive added the S-awaiting-review There is new code that needs to be reviewed. label Nov 26, 2025
@servo-highfive servo-highfive removed the S-awaiting-review There is new code that needs to be reviewed. label Nov 26, 2025
@jschwe jschwe enabled auto-merge November 26, 2025 08:43
@jschwe jschwe added this pull request to the merge queue Nov 26, 2025
@servo-highfive servo-highfive added the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Nov 26, 2025
Merged via the queue into servo:main with commit 710d02c Nov 26, 2025
32 checks passed
@servo-highfive servo-highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Nov 26, 2025
@Narfinger Narfinger deleted the trying-other-version branch November 26, 2025 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants