compositor: Update doc of ExternalScrollId in ScrollResult
#40877
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Euclid Ye <yezhizhenjiakang@gmail.com>
Member
Author
|
No. We can't do this. The |
Member
Author
|
I'll take the opportunity to update the doc. |
This reverts commit 010ec2c. Signed-off-by: Euclid Ye <yezhizhenjiakang@gmail.com>
a8c2435 to
874f15c
Compare
ExternalScrollId in ScrollResultExternalScrollId in ScrollResult
Signed-off-by: Euclid Ye <yezhizhenjiakang@gmail.com>
874f15c to
5c6c8d6
Compare
mrobinson
approved these changes
Nov 25, 2025
Member
mrobinson
left a comment
There was a problem hiding this comment.
Thank you for the clarification here.
Comment on lines
63
to
64
| /// This is necessary as the `external_scroll_id` of [CompositorHitTestResult] can be different. | ||
| /// Currently, we scroll the first possible inclusive ancestor. |
Member
There was a problem hiding this comment.
I suggest a small introduction to the field as well:
Suggested change
| /// This is necessary as the `external_scroll_id` of [CompositorHitTestResult] can be different. | |
| /// Currently, we scroll the first possible inclusive ancestor. | |
| /// The [`ExternalScrollId`] of the node that was actually scrolled. | |
| /// | |
| /// Note that this may be an inclusive ancestor of `external_scroll_id` in | |
| /// [`Self::hit_test_result`]. |
Member
Author
There was a problem hiding this comment.
I will reword a bit.
"this may be an inclusive ancestor" -> "this is an inclusive ancestor"
Signed-off-by: Euclid Ye <yezhizhenjiakang@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original attempt is to remove it. But we can't do this. Add doc to explain why.
Testing: This should change nothing.
Fixes: Preparing for #40663.