fonts: Apply variations for font-weight, font-stretch
#40867
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Simon Wülker <simon.wuelker@arcor.de>
Signed-off-by: Simon Wülker <simon.wuelker@arcor.de>
Signed-off-by: Simon Wülker <simon.wuelker@arcor.de>
simonwuelker
commented
Nov 24, 2025
Comment on lines
+1
to
+2
| [font-variation-settings-descriptor-03.html] | ||
| expected: FAIL |
Contributor
Author
There was a problem hiding this comment.
These two tests fail due to the way we treat font-optical-size:auto. Apparently other browsers don't add opsz if its already present in the font-variation-settings property.
simonwuelker
commented
Nov 24, 2025
| .copied() | ||
| .for_each(&mut add_variation); | ||
|
|
||
| // Step 9. Font variations implied by the value of the font-optical-sizing property are applied. |
Contributor
Author
There was a problem hiding this comment.
Step 9 was in the wrong place previously (steps are in reverse order because variations are listed in ascending order of priority)
TimvdLippe
approved these changes
Nov 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
font-styleis not included yet because it requires us to have information about the selected font, which is not possible yet.Testing: New tests start to pass
Fixes #37236
Part of #38800