script: Align Streams implementation with spec step calls #40856

WaterWhisperer · 2025-11-24T09:14:32Z

updates several methods in ReadableStream to use .expect() instead of ? where the spec indicates an infallible operation (denoted by !).

Testing: mach test-wpt /streams/
Fixes: part of #36906

Signed-off-by: WaterWhisperer <waterwhisperer24@qq.com>

github-actions · 2025-11-24T12:01:03Z

🔨 Triggering try run (#19633552851) for Linux (WPT)

Taym95 · 2025-11-24T12:01:11Z

Thank you for contribution!

github-actions · 2025-11-24T12:54:20Z

Test results for linux-wpt from try job (#19633552851):

Flaky unexpected result (38)

TIMEOUT /FileAPI/url/url-in-tags-revoke.window.html (#19978)
- TIMEOUT [expected PASS] subtest: Fetching a blob URL immediately before revoking it works in <script> tags.
```
Test timed out
```
OK /IndexedDB/idbfactory_open.any.html
- FAIL [expected PASS] subtest: Calling open() with version argument 1.5 should not throw.
```
assert_equals: version expected 1 but got 9007199254740991
```

OK /_mozilla/css/offset_properties_inline.html (#40543)

FAIL [expected PASS] subtest: offsetTop

assert_equals: offsetTop of #inline-1 should be 0. expected 0 but got -1

FAIL [expected PASS] subtest: offsetLeft

assert_equals: offsetLeft of #inline-2 should be 40. expected 40 but got 25

OK /_mozilla/webxr/create_session.https.html
- FAIL [expected PASS] subtest: create_session
```
can't access property "simulateDeviceConnection", navigator.xr.test is undefined
```

OK /_mozilla/webxr/obtain_frame.https.html

FAIL [expected PASS] subtest: obtain_frame

promise_test: Unhandled rejection with value: object "TypeError: can't access property "simulateDeviceConnection", navigator.xr.test is undefined"

FAIL [expected PASS] /css/css-backgrounds/background-size-042.html
FAIL [expected PASS] /css/css-backgrounds/border-image-repeat-space-9.html
OK /custom-elements/form-associated/ElementInternals-setFormValue.html (#29174)
- PASS [expected FAIL] subtest: setFormValue with an empty FormData should submit nothing
CRASH [expected ERROR] /encoding/streams/decode-ignore-bom.any.serviceworker.html
CRASH [expected ERROR] /fetch/api/basic/header-value-null-byte.any.serviceworker.html
CRASH [expected ERROR] /fetch/api/basic/request-headers.any.serviceworker.html

OK /fetch/api/credentials/cookies.any.html (#40672)

FAIL [expected PASS] subtest: Include mode: 1 cookie

assert_equals: Request include cookie(s) expected "a=1" but got "a=1; domain-attribute-matches-host=0"

FAIL [expected PASS] subtest: Include mode: 2 cookies

assert_equals: Request include cookie(s) expected "b=2; c=3" but got "b=2; c=3; domain-attribute-matches-host=0"

FAIL [expected PASS] subtest: Omit mode: no cookie is stored

assert_false: Request does not have cookie(s) expected false got true

FAIL [expected PASS] subtest: Same-origin mode: 1 cookie

assert_equals: Request include cookie(s) expected "a=1" but got "a=1; domain-attribute-matches-host=0"

FAIL [expected PASS] subtest: Same-origin mode: 2 cookies

assert_equals: Request include cookie(s) expected "b=2; c=3" but got "b=2; c=3; domain-attribute-matches-host=0"

CRASH [expected OK] /fetch/api/policies/referrer-origin-service-worker.https.html
CRASH [expected ERROR] /fetch/api/request/request-cache-default-conditional.any.serviceworker.html
CRASH [expected OK] /fetch/compression-dictionary/dictionary-fetch-with-link-header.tentative.https.html
CRASH [expected OK] /fetch/fetch-later/basic.https.window.html
OK /fetch/fetch-later/new-window.https.window.html (#32036)
- FAIL [expected PASS] subtest: A same-origin window[target=''][features=''] can trigger fetchLater.
```
assert_equals: Number of sent beacons does not match expected count: expected 1 but got 0
```
- FAIL [expected PASS] subtest: A same-origin window[target=''][features='popup'] can trigger fetchLater.
```
assert_equals: Number of sent beacons does not match expected count: expected 1 but got 0
```
- FAIL [expected PASS] subtest: A same-origin window[target='_blank'][features=''] can trigger fetchLater.
```
assert_equals: Number of sent beacons does not match expected count: expected 1 but got 0
```
- FAIL [expected PASS] subtest: A same-origin window[target='_blank'][features='popup'] can trigger fetchLater.
```
assert_equals: Number of sent beacons does not match expected count: expected 1 but got 0
```
OK /fetch/fetch-later/permissions-policy/deferred-fetch-allowed-by-permissions-policy.https.window.html (#40478)
- PASS [expected FAIL] subtest: Permissions policy header: "deferred-fetch=*" allows fetchLater() in the top-level document.
ERROR /fetch/metadata/generated/serviceworker.https.sub.html (#36247)
- FAIL [expected PASS] subtest: sec-fetch-site - Same origin, no options - registration
```
promise_test: Unhandled rejection with value: object "Error: Failed to query for recorded headers."
```
CRASH [expected OK] /fetch/metadata/generated/worker-dedicated-importscripts.https.sub.html
OK [expected ERROR] /focus/focus-event-after-switching-iframes.sub.html (#40368)
TIMEOUT [expected CRASH] /html/anonymous-iframe/indexeddb.tentative.https.window.html (#39254)
CRASH [expected OK] /html/browsers/windows/browsing-context-names/choose-_blank-002.html

OK /html/dom/documents/resource-metadata-management/document-cookie.html (#40673)

FAIL [expected PASS] subtest: document has no cookie

assert_equals: expected "" but got "domain-attribute-matches-host=0"

FAIL [expected PASS] subtest: document.cookie

assert_equals: expected "" but got "domain-attribute-matches-host=0"

FAIL [expected PASS] subtest: document.cookie 1

assert_equals: expected "a=b" but got "a=b; domain-attribute-matches-host=0"

FAIL [expected PASS] subtest: document.cookie 2

assert_equals: expected "" but got "a=b; domain-attribute-matches-host=0"

OK [expected TIMEOUT] /html/interaction/focus/the-autofocus-attribute/autofocus-dialog.html (#29087)
- FAIL [expected TIMEOUT] subtest: <dialog>-contained autofocus element gets focused when the dialog is shown
```
assert_equals: expected "DIV" but got "BODY"
```
OK /html/semantics/embedded-content/media-elements/seeking/seek-to-max-value.htm (#40626)
- FAIL [expected PASS] subtest: seek to Number.MAX_VALUE
```
assert_equals: currentTime after setting expected 5.153333333 but got 0
```

OK /html/semantics/embedded-content/the-iframe-element/iframe-loading-lazy-nav-location-assign.html (#32863)

FAIL [expected PASS] subtest: Navigating iframe loading='lazy' before it is loaded: location.assign

uncaught exception: Error: assert_equals: expected "http://web-platform.test:8000/html/semantics/embedded-content/the-iframe-element/support/blank.htm?nav" but got "http://web-platform.test:8000/html/semantics/embedded-content/the-iframe-element/support/blank.htm?src"

OK /html/semantics/embedded-content/the-iframe-element/iframe-loading-lazy-reload-location-reload.html (#32595)
- FAIL [expected PASS] subtest: Reloading iframe loading='lazy' before it is loaded: location.reload
```
uncaught exception: Error: assert_equals: expected "http://web-platform.test:8000/html/semantics/embedded-content/the-iframe-element/support/blank.htm?src" but got "about:blank"
```
OK /html/semantics/forms/form-submission-0/jsurl-form-submit.tentative.html (#36489)
- PASS [expected FAIL] subtest: Verifies that form submissions scheduled inside javascript: urls take precedence over the javascript: url's return value.
OK /html/semantics/forms/form-submission-0/multipart-formdata.window.html (#28725)
- PASS [expected FAIL] subtest: multipart/form-data: 0x00 in value (normal form)
OK /html/semantics/forms/form-submission-0/text-plain.window.html (#28687)
- FAIL [expected PASS] subtest: text/plain: Basic test (formdata event)
```
assert_equals: expected "basic=test\r\n" but got ""
```
- FAIL [expected PASS] subtest: text/plain: Basic File test (normal form)
```
assert_equals: expected "basic=file-test.txt\r\n" but got ""
```
- PASS [expected FAIL] subtest: text/plain: double quote in value (normal form)
OK /html/semantics/forms/form-submission-0/urlencoded2.window.html (#28687)
- FAIL [expected PASS] subtest: application/x-www-form-urlencoded: Basic File test (normal form)
```
assert_equals: expected "basic=file-test.txt" but got ""
```
- PASS [expected FAIL] subtest: application/x-www-form-urlencoded: 0x00 in name (normal form)
- PASS [expected FAIL] subtest: application/x-www-form-urlencoded: 0x00 in value (formdata event)
OK [expected CRASH] /html/semantics/forms/the-fieldset-element/disabled-003.html (#31730, #39631)
CRASH [expected OK] /trusted-types/block-string-assignment-to-DedicatedWorker-setTimeout-setInterval.html
TIMEOUT /trusted-types/trusted-types-navigation.html?31-35 (#38034)
- TIMEOUT [expected PASS] subtest: Navigate a frame via form-submission with javascript:-urls in report-only mode.
```
Test timed out
```
- NOTRUN [expected TIMEOUT] subtest: Navigate a frame via form-submission with javascript:-urls w/ default policy in report-only mode.
CRASH [expected OK] /wasm/webapi/esm-integration/wasm-to-wasm-link-error.tentative.html
OK [expected TIMEOUT] /webstorage/localstorage-about-blank-3P-iframe-opens-3P-window.partitioned.html (#29053)
- PASS [expected TIMEOUT] subtest: StorageKey: test 3P about:blank window opened from a 3P iframe
OK /webxr/xrSession_features_deviceSupport.https.html (#24357)
- FAIL [expected PASS] subtest: Immersive XRSession requests with no supported device should reject
```
assert_unreached: Should have rejected: undefined Reached unreachable code
```

Stable unexpected results that are known to be intermittent (28)

OK /IndexedDB/idbobjectstore_getAll.any.html (#39276)
- PASS [expected FAIL] subtest: Get all values with transaction.commit()
OK /IndexedDB/idbobjectstore_getAll.any.worker.html (#39400)
- PASS [expected FAIL] subtest: Get all values with transaction.commit()
FAIL [expected PASS] /_mozilla/mozilla/sslfail.html (#10760)
TIMEOUT [expected OK] /_mozilla/mozilla/window_resize_event.html (#36741)
- TIMEOUT [expected PASS] subtest: Popup onresize event fires after resizeTo
```
Test timed out
```
TIMEOUT /content-security-policy/inheritance/location-reload.html (#38983)
- PASS [expected FAIL] subtest: location.reload() of empty iframe.
OK /cookiestore/cookieStore_getAll_set_creation_url.https.any.html (#40695)
- FAIL [expected PASS] subtest: cookieStore.set and cookieStore.getAll use the creation url
```
assert_equals: expected 1 but got 2
```
TIMEOUT [expected OK] /credential-management/credentialscontainer-frame-basics.https.html (#39430)
- TIMEOUT [expected FAIL] subtest: navigator.credentials should be undefined in documents generated from data: URLs.
```
Test timed out
```
OK /css/css-fonts/generic-family-keywords-001.html (#37467)
- FAIL [expected PASS] subtest: @font-face matching for quoted and unquoted generic(khmer-mul)
```
assert_equals: quoted generic(khmer-mul) matches  @font-face rule expected 50 but got 30
```
- PASS [expected FAIL] subtest: @font-face matching for quoted and unquoted generic(nastaliq)
OK /css/css-fonts/generic-family-keywords-003.html (#38994)
- PASS [expected FAIL] subtest: @font-face matching for quoted and unquoted ui-serif (drawing text in a canvas)
FAIL [expected PASS] /css/css-grid/grid-lanes/tentative/alignment/row-grid-lanes-align-self-003.html (#40833)
FAIL [expected PASS] /css/css-grid/grid-lanes/tentative/grid-placement/row-explicit-placement-004.html (#40834)
FAIL [expected PASS] /css/css-grid/masonry/tentative/subgrid/column/masonry-subgrid-002f.html (#40830)
OK /fetch/metadata/generated/css-font-face.https.sub.tentative.html (#32732)
- PASS [expected FAIL] subtest: sec-fetch-mode
- FAIL [expected PASS] subtest: sec-fetch-storage-access - Cross-site
```
promise_test: Unhandled rejection with value: object "Error: Failed to query for recorded headers."
```
OK /fetch/metadata/generated/css-font-face.sub.tentative.html (#34624)
- FAIL [expected PASS] subtest: sec-fetch-storage-access - Not sent to non-trustworthy same-origin destination
```
promise_test: Unhandled rejection with value: object "Error: Failed to query for recorded headers."
```
- PASS [expected FAIL] subtest: sec-fetch-storage-access - Not sent to non-trustworthy cross-site destination
OK /fetch/metadata/generated/element-img-environment-change.https.sub.html (#30111)
- FAIL [expected PASS] subtest: sec-fetch-site - Same-Origin -> Same-Site -> Same-Origin redirect, no attributes
```
promise_test: Unhandled rejection with value: object "Error: Failed to query for recorded headers."
```
- PASS [expected FAIL] subtest: sec-fetch-site - Cross-Site -> Same Origin, no attributes
- FAIL [expected PASS] subtest: sec-fetch-site - Cross-Site -> Same-Site, no attributes
```
promise_test: Unhandled rejection with value: object "Error: Failed to query for recorded headers."
```
- PASS [expected FAIL] subtest: sec-fetch-site - Same-Origin -> Same Origin, no attributes
- FAIL [expected PASS] subtest: sec-fetch-site - Same-Origin -> Cross-Site, no attributes
```
promise_test: Unhandled rejection with value: object "Error: Failed to query for recorded headers."
```
- PASS [expected FAIL] subtest: sec-fetch-site - Same-Site -> Same Origin, no attributes
- FAIL [expected PASS] subtest: sec-fetch-site - Same-Site -> Same-Site, no attributes
```
promise_test: Unhandled rejection with value: object "Error: Failed to query for recorded headers."
```
- PASS [expected FAIL] subtest: sec-fetch-site - Same-Site -> Cross-Site, no attributes
- PASS [expected FAIL] subtest: sec-fetch-storage-access - Same site, no attributes
OK /fetch/metadata/generated/element-img-environment-change.sub.html (#30111)
- PASS [expected FAIL] subtest: sec-fetch-site - Not sent to non-trustworthy same-site destination, no attributes
- PASS [expected FAIL] subtest: sec-fetch-site - Not sent to non-trustworthy cross-site destination, no attributes
- FAIL [expected PASS] subtest: sec-fetch-mode - Not sent to non-trustworthy same-origin destination, no attributes
```
promise_test: Unhandled rejection with value: object "Error: Failed to query for recorded headers."
```
- PASS [expected FAIL] subtest: sec-fetch-mode - Not sent to non-trustworthy same-site destination, no attributes
- PASS [expected FAIL] subtest: sec-fetch-mode - Not sent to non-trustworthy cross-site destination, no attributes
- PASS [expected FAIL] subtest: sec-fetch-dest - Not sent to non-trustworthy cross-site destination, no attributes
- PASS [expected FAIL] subtest: sec-fetch-user - Not sent to non-trustworthy cross-site destination, no attributes
OK /html/browsers/browsing-the-web/navigating-across-documents/navigation-unload-same-origin-fragment.html (#20768)
- PASS [expected FAIL] subtest: Tests that a fragment navigation in the unload handler will not block the initial navigation
OK /html/browsers/history/the-history-interface/traverse_the_history_3.html (#21383)
- PASS [expected FAIL] subtest: Multiple history traversals, last would be aborted
TIMEOUT /html/interaction/focus/the-autofocus-attribute/supported-elements.html (#24145)
- FAIL [expected TIMEOUT] subtest: Element with tabindex should support autofocus
```
assert_equals: expected "SPAN" but got "BODY"
```
- PASS [expected NOTRUN] subtest: Non-HTMLElement should not support autofocus
- FAIL [expected NOTRUN] subtest: Host element with delegatesFocus should support autofocus
```
assert_equals: expected Element node &lt;div autofocus=""&gt;&lt;/div&gt; but got Element node &lt;body&gt;&lt;div autofocus=""&gt;&lt;/div&gt;&lt;/body&gt;
```
- TIMEOUT [expected NOTRUN] subtest: Host element with delegatesFocus including no focusable descendants should be skipped
```
Test timed out
```
TIMEOUT [expected OK] /html/interaction/focus/the-autofocus-attribute/update-the-rendering.html (#24145)
- TIMEOUT [expected FAIL] subtest: "Flush autofocus candidates" should be happen before a scroll event and animation frame callbacks
```
Test timed out
```
OK /navigation-timing/test-navigation-type-reload.html (#33334)
- PASS [expected FAIL] subtest: Reload domContentLoadedEventStart > Original domContentLoadedEventStart
- PASS [expected FAIL] subtest: Reload fetchStart > Original fetchStart
CRASH [expected OK] /pointerevents/compat/pointerevent_touch-action_two-finger_interaction.html (#40418)
OK /preload/prefetch-document.html (#37210)
- FAIL [expected PASS] subtest: different-site document prefetch with 'as=document' should not be consumed
```
assert_equals: expected 2 but got 1
```
OK /preload/preload-error.sub.html (#37177)
- PASS [expected FAIL] subtest: CORS (fetch): main
OK /preload/preload-xhr.html (#39092)
- FAIL [expected PASS] subtest: Make an XHR request immediately after creating link rel=preload.
```
assert_equals: resources/dummy.xml?token=f25ed8d0-a5a3-401d-8c73-c2cb61e8614d expected 1 but got 0
```
OK /resource-timing/buffer-full-add-then-clear.html (#40819)
- FAIL [expected PASS] subtest: Test that if the buffer is cleared after entries were added to the secondary buffer, those entries make it into the primary one
```
assert_equals: Number of entries does not match the expected value. expected 3 but got 0
```
OK [expected ERROR] /resource-timing/cors-preflight.any.html (#28694)
TIMEOUT [expected OK] /trusted-types/trusted-types-navigation.html?26-30 (#38807)
- TIMEOUT [expected FAIL] subtest: Navigate a window via form-submission with javascript:-urls in report-only mode.
```
Test timed out
```
- NOTRUN [expected PASS] subtest: Navigate a window via form-submission with javascript:-urls w/ default policy in report-only mode.
- NOTRUN [expected FAIL] subtest: Navigate a frame via form-submission with javascript:-urls in enforcing mode.
- NOTRUN [expected PASS] subtest: Navigate a frame via form-submission with javascript:-urls w/ default policy in enforcing mode.

github-actions · 2025-11-24T12:54:27Z

✨ Try run (#19633552851) succeeded.

script: Align Streams implementation with spec step calls

52edd60

Signed-off-by: WaterWhisperer <waterwhisperer24@qq.com>

WaterWhisperer requested a review from gterzian as a code owner November 24, 2025 09:14

servo-highfive added the S-awaiting-review There is new code that needs to be reviewed. label Nov 24, 2025

Taym95 added the T-linux-wpt Do a try run of the WPT label Nov 24, 2025

github-actions bot removed the T-linux-wpt Do a try run of the WPT label Nov 24, 2025

Taym95 approved these changes Nov 24, 2025

View reviewed changes

servo-highfive removed the S-awaiting-review There is new code that needs to be reviewed. label Nov 24, 2025

Taym95 added this pull request to the merge queue Nov 24, 2025

servo-highfive added the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Nov 24, 2025

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 24, 2025

servo-highfive added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Nov 24, 2025

Taym95 added this pull request to the merge queue Nov 24, 2025

servo-highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-tests-failed The changes caused existing tests to fail. labels Nov 24, 2025

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 24, 2025

servo-highfive added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Nov 24, 2025

Taym95 added this pull request to the merge queue Nov 24, 2025

servo-highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-tests-failed The changes caused existing tests to fail. labels Nov 24, 2025

Merged via the queue into servo:main with commit 687ba76 Nov 24, 2025
85 checks passed

servo-highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Nov 24, 2025

WaterWhisperer deleted the streams-step-calls-cleanup branch November 25, 2025 04:36

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

script: Align Streams implementation with spec step calls #40856

script: Align Streams implementation with spec step calls #40856

Uh oh!

WaterWhisperer commented Nov 24, 2025

Uh oh!

github-actions bot commented Nov 24, 2025

Uh oh!

Taym95 commented Nov 24, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Nov 24, 2025

Uh oh!

github-actions bot commented Nov 24, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

script: Align Streams implementation with spec step calls #40856

script: Align Streams implementation with spec step calls #40856

Uh oh!

Conversation

WaterWhisperer commented Nov 24, 2025

Uh oh!

github-actions bot commented Nov 24, 2025

Uh oh!

Taym95 commented Nov 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Nov 24, 2025

Uh oh!

github-actions bot commented Nov 24, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Taym95 commented Nov 24, 2025 •

edited

Loading