Skip to content

Implement brotli support for CompressionStream and DecompressionStream #40842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jdm merged 3 commits into from
Nov 25, 2025
Merged

Implement brotli support for CompressionStream and DecompressionStream #40842

jdm merged 3 commits into from
Nov 25, 2025

Conversation

@Taym95
Copy link
Member

@Taym95 Taym95 commented Nov 23, 2025

Implement brotli support for CompressionStream and DecompressionStream

Testing: brotli test should pass
Fixes: #40831

@Taym95 Taym95 requested a review from gterzian as a code owner November 23, 2025 20:06
@servo-highfive servo-highfive added the S-awaiting-review There is new code that needs to be reviewed. label Nov 23, 2025
@Taym95
Implement brotli support for CompressionStream and DecompressionStream
05117f2 
Signed-off-by: Taym Haddadi <haddadi.taym@gmail.com>
@Taym95 Taym95 force-pushed the Implement-brotli-support-for-CompressionStream-and-DecompressionStream branch from 2681af7 to 05117f2 Compare November 23, 2025 22:48
kkoyung
kkoyung reviewed Nov 24, 2025
View reviewed changes
Copy link
Member

@kkoyung kkoyung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A log file is accidentally included in the PR.

@Taym95
measure the size of the boxed encoder
b38b630 
Signed-off-by: Taym Haddadi <haddadi.taym@gmail.com>
kkoyung
kkoyung reviewed Nov 24, 2025
View reviewed changes
@Taym95
Measuring only the brotli_encoder and brotli_dencoder
6ffa183 
Signed-off-by: Taym Haddadi <haddadi.taym@gmail.com>
@servo-highfive servo-highfive removed the S-awaiting-review There is new code that needs to be reviewed. label Nov 24, 2025
jdm
jdm approved these changes Nov 25, 2025
View reviewed changes
Copy link
Member

@jdm jdm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the initial review @kkoyung !

@jdm jdm added this pull request to the merge queue Nov 25, 2025
@servo-highfive servo-highfive added the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Nov 25, 2025
Merged via the queue into servo:main with commit 42ea536 Nov 25, 2025
32 checks passed
@servo-highfive servo-highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Nov 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jdm jdm jdm approved these changes

@gterzian gterzian Awaiting requested review from gterzian gterzian is a code owner

+1 more reviewer

@kkoyung kkoyung kkoyung approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Implement brotli support for CompressionStream and DecompressionStream

4 participants

@Taym95 @jdm @kkoyung @servo-highfive