webdriver: Enable implicit wait on error #40836

yezhizhen · 2025-11-23T10:35:24Z

... and reduce code duplication in element retrieval. Note that we are not using the functionality of "wait on error" yet.

Testing: We added WPT tests for "Find element", "Find element from element", "Find element from shadow root" for both successful implicit wait and timeout case.

components/webdriver_server/lib.rs

Signed-off-by: Euclid Ye <yezhizhenjiakang@gmail.com>

yezhizhen · 2025-11-26T05:37:00Z

~~This is a good opportunity to add wpt test for this functionality. Maybe in another PR.~~

I did it here.

Signed-off-by: Euclid Ye <yezhizhenjiakang@gmail.com>

servo-wpt-sync · 2025-11-26T08:42:02Z

🤖 Opened new upstream WPT pull request (web-platform-tests/wpt#56292) with upstreamable changes.

Signed-off-by: Euclid Ye <yezhizhenjiakang@gmail.com>

servo-wpt-sync · 2025-11-26T08:42:52Z

✍ Updated existing upstream WPT pull request (web-platform-tests/wpt#56292) title and body.

servo-wpt-sync · 2025-11-26T08:45:56Z

📝 Transplanted new upstreamable changes to existing upstream WPT pull request (web-platform-tests/wpt#56292).

Signed-off-by: Euclid Ye <yezhizhenjiakang@gmail.com>

servo-wpt-sync · 2025-11-26T08:49:45Z

📝 Transplanted new upstreamable changes to existing upstream WPT pull request (web-platform-tests/wpt#56292).

servo-wpt-sync · 2025-11-26T08:55:49Z

✍ Updated existing upstream WPT pull request (web-platform-tests/wpt#56292) title and body.

yezhizhen · 2025-11-26T08:57:59Z

We can also add tests for plural command (Elements) if really want.. But I'm exhausted.

TimvdLippe · 2025-11-27T07:48:27Z

Ugh. The GitHub UI jumped around and now I accidentally clicked update...

servo-wpt-sync · 2025-11-27T07:50:59Z

📝 Transplanted new upstreamable changes to existing upstream WPT pull request (web-platform-tests/wpt#56292).

yezhizhen · 2025-11-27T08:41:48Z

Ugh. The GitHub UI jumped around and now I accidentally clicked update...

Somehow upstream export got closed after it. I will repush this.

Thanks for the review!

servo-wpt-sync · 2025-11-27T08:48:24Z

🤖 Opened new upstream WPT pull request (web-platform-tests/wpt#56324) with upstreamable changes.

whimboo · 2025-11-27T16:32:38Z

tests/wpt/tests/webdriver/tests/classic/find_element/find.py

+            }, 300);
+        </script>
+    """)
+    session.timeouts.implicit = 1


FYI. The timeout should be reset to its default value at the end of the test. I'm going to do that once the patch landed in our Firefox repository. I've filed https://bugzilla.mozilla.org/show_bug.cgi?id=2002826 for it.

For the future feel free to ask for review for tests as well. I'm happy to give feedback for changes or additions to webdriver tests.

Thanks for reaching out!

But it seems the harness already automatically reset timeout everytime, when starting a new subtest? Is this really necessary?

servo/tests/wpt/tests/webdriver/tests/support/fixtures.py

Line 192 in 4f02ee5

_current_session.timeouts.implicit = IMPLICIT_WAIT_TIMEOUT * multiplier

which is fixed to 0.

I also see other tests that sets the implicit wait, without resetting them.

servo/tests/wpt/tests/webdriver/tests/classic/switch_to_frame/switch.py

Lines 111 to 112 in 4f02ee5

def test_find_element_while_frame_is_still_loading(session, url):

session.timeouts.implicit = 5

We only end and start a new session when the capabilities have changed. So normally it won't happen for all the tests that are part of a file. Thanks for finding this additional test. I'll take a look for that as well.

And following two.

servo/tests/wpt/tests/webdriver/tests/classic/get_timeouts/get.py

Lines 26 to 29 in b00a764

def test_get_new_timeouts(session):

session.timeouts.script = 60

session.timeouts.implicit = 1

session.timeouts.page_load = 200

servo/tests/wpt/tests/webdriver/tests/classic/set_timeouts/set.py

Lines 81 to 82 in b00a764

def test_set_all_fields(session):

timeouts = {"implicit": 10, "pageLoad": 20, "script": 30}

servo-highfive added the S-awaiting-review There is new code that needs to be reviewed. label Nov 23, 2025

yezhizhen force-pushed the wait-on-error branch from a2ee51f to 8f0e926 Compare November 23, 2025 10:39

yezhizhen requested a review from TimvdLippe November 25, 2025 08:08

TimvdLippe reviewed Nov 25, 2025

View reviewed changes

components/webdriver_server/lib.rs Outdated Show resolved Hide resolved

yezhizhen added 4 commits November 26, 2025 10:41

Allow wait on error

a1e9527

Signed-off-by: Euclid Ye <yezhizhenjiakang@gmail.com>

Do not use type alias

50547d2

Signed-off-by: Euclid Ye <yezhizhenjiakang@gmail.com>

only fmt

51a0e07

Signed-off-by: Euclid Ye <yezhizhenjiakang@gmail.com>

Remove CAN_EARLY_RETURN

a594322

Signed-off-by: Euclid Ye <yezhizhenjiakang@gmail.com>

yezhizhen force-pushed the wait-on-error branch from 8f0e926 to a594322 Compare November 26, 2025 02:42

Use enum

4a1ac11

Signed-off-by: Euclid Ye <yezhizhenjiakang@gmail.com>

yezhizhen force-pushed the wait-on-error branch from 85e0d06 to 4a1ac11 Compare November 26, 2025 03:25

yezhizhen added 3 commits November 26, 2025 16:37

Add implicit wait test for "find element"

7418c2b

Signed-off-by: Euclid Ye <yezhizhenjiakang@gmail.com>

Add implicit wait test for "find element from element"

4bddd54

Signed-off-by: Euclid Ye <yezhizhenjiakang@gmail.com>

Add implicit wait test for "find element from shadow root"

2841e25

Signed-off-by: Euclid Ye <yezhizhenjiakang@gmail.com>

servo-wpt-sync mentioned this pull request Nov 26, 2025

webdriver: Enable implicit wait on error web-platform-tests/wpt#56292

Closed

manifest

8b780e4

Signed-off-by: Euclid Ye <yezhizhenjiakang@gmail.com>

yezhizhen force-pushed the wait-on-error branch from f522bec to 8b780e4 Compare November 26, 2025 08:42

Add reason for dead_code expectation

416bccc

Signed-off-by: Euclid Ye <yezhizhenjiakang@gmail.com>

yezhizhen requested a review from TimvdLippe November 26, 2025 08:50

TimvdLippe approved these changes Nov 27, 2025

View reviewed changes

servo-highfive removed the S-awaiting-review There is new code that needs to be reviewed. label Nov 27, 2025

TimvdLippe enabled auto-merge November 27, 2025 07:48

servo-highfive added the S-awaiting-review There is new code that needs to be reviewed. label Nov 27, 2025

TimvdLippe added this pull request to the merge queue Nov 27, 2025

servo-highfive added the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Nov 27, 2025

yezhizhen removed this pull request from the merge queue due to a manual request Nov 27, 2025

servo-highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Nov 27, 2025

yezhizhen force-pushed the wait-on-error branch from bd8420b to 416bccc Compare November 27, 2025 08:42

servo-wpt-sync mentioned this pull request Nov 27, 2025

webdriver: Enable implicit wait on error web-platform-tests/wpt#56324

Merged

yezhizhen added this pull request to the merge queue Nov 27, 2025

servo-highfive added the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Nov 27, 2025

Merged via the queue into servo:main with commit f9c0fc8 Nov 27, 2025
55 checks passed

yezhizhen deleted the wait-on-error branch November 27, 2025 09:58

servo-highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Nov 27, 2025

whimboo reviewed Nov 27, 2025

View reviewed changes

	def test_find_element_while_frame_is_still_loading(session, url):
	session.timeouts.implicit = 5

	def test_get_new_timeouts(session):
	session.timeouts.script = 60
	session.timeouts.implicit = 1
	session.timeouts.page_load = 200

	def test_set_all_fields(session):
	timeouts = {"implicit": 10, "pageLoad": 20, "script": 30}

Uh oh!

webdriver: Enable implicit wait on error #40836

webdriver: Enable implicit wait on error #40836

Uh oh!

Conversation

yezhizhen commented Nov 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

yezhizhen commented Nov 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

servo-wpt-sync commented Nov 26, 2025

Uh oh!

servo-wpt-sync commented Nov 26, 2025

Uh oh!

servo-wpt-sync commented Nov 26, 2025

Uh oh!

servo-wpt-sync commented Nov 26, 2025

Uh oh!

servo-wpt-sync commented Nov 26, 2025

Uh oh!

yezhizhen commented Nov 26, 2025

Uh oh!

TimvdLippe commented Nov 27, 2025

Uh oh!

servo-wpt-sync commented Nov 27, 2025

Uh oh!

Uh oh!

yezhizhen commented Nov 27, 2025

Uh oh!

servo-wpt-sync commented Nov 27, 2025

Uh oh!

Uh oh!

whimboo Nov 27, 2025

Choose a reason for hiding this comment

Uh oh!

yezhizhen Nov 28, 2025

Choose a reason for hiding this comment

Uh oh!

yezhizhen Nov 28, 2025

Choose a reason for hiding this comment

Uh oh!

yezhizhen Nov 28, 2025

Choose a reason for hiding this comment

Uh oh!

whimboo Nov 28, 2025

Choose a reason for hiding this comment

Uh oh!

yezhizhen Nov 29, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

yezhizhen commented Nov 23, 2025 •

edited

Loading

yezhizhen commented Nov 26, 2025 •

edited

Loading