Skip to content

servodriver: Fix incorrect method name. #40835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jdm merged 1 commit into from
Nov 23, 2025
Merged

servodriver: Fix incorrect method name. #40835

jdm merged 1 commit into from
Nov 23, 2025

Conversation

@jdm
Copy link
Member

@jdm jdm commented Nov 23, 2025

Fixes the following error that occurs when servodriver shutdown times out:

Uncaught exception in TestRunnerManager.run:
Traceback (most recent call last):
  File "/Users/jdm/src/alt-servo/tests/wpt/tests/tools/wptrunner/wptrunner/testrunner.py", line 441, in run_loop
    new_state = f()
                ^^^
  File "/Users/jdm/src/alt-servo/tests/wpt/tests/tools/wptrunner/wptrunner/testrunner.py", line 936, in restart_runner
    self.stop_runner(force=self.state.force_stop)
  File "/Users/jdm/src/alt-servo/tests/wpt/tests/tools/wptrunner/wptrunner/testrunner.py", line 959, in stop_runner
    self.browser.stop(force=True)
  File "/Users/jdm/src/alt-servo/tests/wpt/tests/tools/wptrunner/wptrunner/testrunner.py", line 292, in stop
    self.browser.stop(force=force)
  File "/Users/jdm/src/alt-servo/tests/wpt/tests/tools/wptrunner/wptrunner/browsers/servodriver.py", line 172, in stop
    self.logger.warn("Max retry exceeded to normally shut down. Killing instead.")
    ^^^^^^^^^^^^^^^^
AttributeError: 'StructuredLogger' object has no attribute 'warn'

Testing: Manual test. Can't test the test harness.

@servo-highfive servo-highfive added the S-awaiting-review There is new code that needs to be reviewed. label Nov 23, 2025
@servo-wpt-sync
Copy link
Collaborator

servo-wpt-sync commented Nov 23, 2025

🤖 Opened new upstream WPT pull request (web-platform-tests/wpt#56209) with upstreamable changes.

@servo-wpt-sync servo-wpt-sync mentioned this pull request Nov 23, 2025
Merged
@servo-highfive servo-highfive removed the S-awaiting-review There is new code that needs to be reviewed. label Nov 23, 2025
@jdm
servodriver: Fix incorrect method name.
a1d1697 
Signed-off-by: Josh Matthews <josh@joshmatthews.net>
@jdm jdm enabled auto-merge November 23, 2025 07:57
@servo-highfive servo-highfive added the S-awaiting-review There is new code that needs to be reviewed. label Nov 23, 2025
@servo-wpt-sync
Copy link
Collaborator

servo-wpt-sync commented Nov 23, 2025

📝 Transplanted new upstreamable changes to existing upstream WPT pull request (web-platform-tests/wpt#56209).

@jdm jdm added this pull request to the merge queue Nov 23, 2025
@servo-highfive servo-highfive added the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Nov 23, 2025
@servo-highfive servo-highfive removed the S-awaiting-review There is new code that needs to be reviewed. label Nov 23, 2025
@yezhizhen
Copy link
Member

yezhizhen commented Nov 23, 2025

My bad!

Merged via the queue into main with commit 0a54d23 Nov 23, 2025
35 checks passed
@jdm jdm deleted the jdm-patch-58 branch November 23, 2025 09:15
@servo-highfive servo-highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Nov 23, 2025
@mrobinson mrobinson mentioned this pull request Jan 2, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TimvdLippe TimvdLippe TimvdLippe approved these changes

@yezhizhen yezhizhen yezhizhen approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@jdm @servo-wpt-sync @yezhizhen @TimvdLippe @servo-highfive